linux-kernel - Re: [PATCH v5 1/2] Bluetooth: btusb: Record debug log for Mediatek Chip.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <22F94464-EF65-4676-AC61-1E13E22A837F@holtmann.org>
Date:   Thu, 5 Aug 2021 15:12:48 +0200
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Tedd Ho-Jeong An <tedd.an@...ux.intel.com>
Cc:     Mark-YW.Chen@...iatek.com, Johan Hedberg <johan.hedberg@...il.com>,
        chris.lu@...iatek.com, will-cy.lee@...iatek.com,
        Sean Wang <sean.wang@...iatek.com>,
        BlueZ <linux-bluetooth@...r.kernel.org>,
        linux-mediatek@...ts.infradead.org,
        open list <linux-kernel@...r.kernel.org>,
        Michael Sun <michaelfsun@...gle.com>, shawnku@...gle.com,
        jemele@...gle.com, Archie Pusaka <apusaka@...gle.com>,
        Miao-chen Chou <mcchou@...omium.org>
Subject: Re: [PATCH v5 1/2] Bluetooth: btusb: Record debug log for Mediatek
 Chip.

Hi Tedd,

> I cannot find the original patch email and CI report, however this patch throws this warning.
> 
> drivers/bluetooth/btusb.c: In function ‘btusb_recv_acl_mtk’:
> drivers/bluetooth/btusb.c:4033:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
> 4033 |   usb_disable_autosuspend(data->udev);
>      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/bluetooth/btusb.c:4034:2: note: here
> 4034 |  case 0x05ff:  /* Firmware debug logging 1 */
>      |  ^~~~

the /* fall through */ comment is missing.

Regards

Marcel