linux-kernel - Re: [PATCH v1 1/1] wwan: core: Avoid returning error pointer from wwan_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YQz75yaecp016zOb@smile.fi.intel.com>
Date:   Fri, 6 Aug 2021 12:07:51 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Loic Poulain <loic.poulain@...aro.org>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Sergey Ryazanov <ryazanov.s.a@...il.com>,
        Network Development <netdev@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        Johannes Berg <johannes@...solutions.net>,
        Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH v1 1/1] wwan: core: Avoid returning error pointer from
 wwan_create_dev()

On Thu, Aug 05, 2021 at 09:53:57PM +0200, Loic Poulain wrote:
> On Thu, 5 Aug 2021 at 20:38, Andy Shevchenko
> <andriy.shevchenko@...ux.intel.com> wrote:
> >
> > wwan_create_dev() is expected to return either valid pointer or NULL,
> > In some cases it might return the error pointer. Prevent this by converting
> > it to NULL after wwan_dev_get_by_parent().
> 
> wwan_create_dev is called both from wwan_register_ops() and
> wwan_create_port(), one using IS_ERR and the other using NULL testing,
> they should be aligned as well.

Ah, good catch!

I just sent v2, but eventually I have decided to switch to error pointer since
it seems the most used pattern in the code.

-- 
With Best Regards,
Andy Shevchenko