linux-kernel - Re: [PATCH] reset: reset-zynqmp: Fixed the argument data type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHTX3d+OaDuh5d=LCCQTapSkfEosyCFWrStbjBwySgK47Q4YQA@mail.gmail.com>
Date:   Fri, 6 Aug 2021 12:25:21 +0200
From:   Michal Simek <monstr@...str.eu>
To:     LKML <linux-kernel@...r.kernel.org>,
        Michal Simek <monstr@...str.eu>, git <git@...inx.com>
Cc:     Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@...inx.com>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        linux-arm <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] reset: reset-zynqmp: Fixed the argument data type

Hi Philipp,

st 23. 6. 2021 v 13:46 odesílatel Michal Simek <michal.simek@...inx.com> napsal:
>
> From: Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@...inx.com>
>
> This patch changes the data type of the variable 'val' from
> int to u32.
>
> Addresses-Coverity: argument of type "int *" is incompatible with parameter of type "u32 *"
> Signed-off-by: Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@...inx.com>
> Signed-off-by: Michal Simek <michal.simek@...inx.com>
> ---
>
>  drivers/reset/reset-zynqmp.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/reset/reset-zynqmp.c b/drivers/reset/reset-zynqmp.c
> index daa425e74c96..59dc0ff9af9e 100644
> --- a/drivers/reset/reset-zynqmp.c
> +++ b/drivers/reset/reset-zynqmp.c
> @@ -53,7 +53,8 @@ static int zynqmp_reset_status(struct reset_controller_dev *rcdev,
>                                unsigned long id)
>  {
>         struct zynqmp_reset_data *priv = to_zynqmp_reset_data(rcdev);
> -       int val, err;
> +       int err;
> +       u32 val;
>
>         err = zynqmp_pm_reset_get_status(priv->data->reset_id + id, &val);
>         if (err)
> --
> 2.32.0
>

Can you please take a look at this patch?

Thanks,
Michal


-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs