linux-kernel - Re: [PATCH] reset: reset-zynqmp: Fixed the argument data type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210811103621.GA23827@pengutronix.de>
Date:   Wed, 11 Aug 2021 12:36:21 +0200
From:   Michael Tretter <m.tretter@...gutronix.de>
To:     Michal Simek <michal.simek@...inx.com>
Cc:     linux-kernel@...r.kernel.org, monstr@...str.eu, git@...inx.com,
        Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@...inx.com>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        linux-arm-kernel@...ts.infradead.org, kernel@...gutronix.de
Subject: Re: [PATCH] reset: reset-zynqmp: Fixed the argument data type

On Wed, 23 Jun 2021 13:46:20 +0200, Michal Simek wrote:
> From: Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@...inx.com>
> 
> This patch changes the data type of the variable 'val' from
> int to u32.
> 
> Signed-off-by: Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@...inx.com>
> Signed-off-by: Michal Simek <michal.simek@...inx.com>
> Addresses-Coverity: argument of type "int *" is incompatible with parameter of type "u32 *"
> ---
> 
>  drivers/reset/reset-zynqmp.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/reset/reset-zynqmp.c b/drivers/reset/reset-zynqmp.c
> index daa425e74c96..59dc0ff9af9e 100644
> --- a/drivers/reset/reset-zynqmp.c
> +++ b/drivers/reset/reset-zynqmp.c
> @@ -53,7 +53,8 @@ static int zynqmp_reset_status(struct reset_controller_dev *rcdev,
>  			       unsigned long id)
>  {
>  	struct zynqmp_reset_data *priv = to_zynqmp_reset_data(rcdev);
> -	int val, err;
> +	int err;
> +	u32 val;

The function returns val as int instead of u32. While this shouldn't be a
problem in this case, maybe there should be an additional check just to be
sure?

Michael

>  
>  	err = zynqmp_pm_reset_get_status(priv->data->reset_id + id, &val);
>  	if (err)
> -- 
> 2.32.0