linux-kernel - Re: [PATCH 2/2] iio: potentiometer: Add driver support for AD5110

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c5b787e6-8022-ff53-bd78-4e57b80485f2@gmail.com>
Date:   Sat, 7 Aug 2021 22:58:44 +0530
From:   Mugilraj Dhavachelvan <dmugil2000@...il.com>
To:     Lars-Peter Clausen <lars@...afoo.de>, Dragos.Bogdan@...log.com,
        Darius.Berghe@...log.com, Rob Herring <robh+dt@...nel.org>,
        Jonathan Cameron <jic23@...nel.org>,
        Michael Hennerich <Michael.Hennerich@...log.com>,
        Guenter Roeck <linux@...ck-us.net>,
        Chris Packham <chris.packham@...iedtelesis.co.nz>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-iio@...r.kernel.org
Subject: Re: [PATCH 2/2] iio: potentiometer: Add driver support for AD5110



On 07/08/21 5:47 pm, Lars-Peter Clausen wrote:
> On 8/7/21 7:08 AM, Mugilraj Dhavachelvan wrote:
>> +static const struct iio_chan_spec ad5110_channels[] = {
>> +    {
>> +        .type = IIO_RESISTANCE,
>> +        .output = 1,
>> +        .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) | BIT(IIO_CHAN_INFO_OFFSET),
>> +        .info_mask_shared_by_type = BIT(IIO_CHAN_INFO_SCALE) |
>> +                        BIT(IIO_CHAN_INFO_ENABLE),
> There is only on channel in this device. Why are some `separate` and others `shared_by_type`?
> 
No special reason, I'll put everything into 'separate'. Fixed in v2.
>