linux-kernel - [PATCH] firmware: arm_scmi: fix boolconv.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210807173127.GA43248@a24dbc127934>
Date:   Sun, 8 Aug 2021 01:31:27 +0800
From:   kernel test robot <lkp@...el.com>
To:     Igor Skalkin <igor.skalkin@...nsynergy.com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        Sudeep Holla <sudeep.holla@....com>,
        Peter Hilber <peter.hilber@...nsynergy.com>,
        Cristian Marussi <cristian.marussi@....com>,
        linux-arm-kernel@...ts.infradead.org
Subject: [PATCH] firmware: arm_scmi: fix boolconv.cocci warnings

From: kernel test robot <lkp@...el.com>

drivers/firmware/arm_scmi/virtio.c:225:40-45: WARNING: conversion to bool not needed here

 Remove unneeded conversion to bool

Semantic patch information:
 Relational and logical operators evaluate to bool,
 explicit conversion is overly verbose and unneeded.

Generated by: scripts/coccinelle/misc/boolconv.cocci

CC: Igor Skalkin <igor.skalkin@...nsynergy.com>
Reported-by: kernel test robot <lkp@...el.com>
Signed-off-by: kernel test robot <lkp@...el.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/sudeep.holla/linux.git for-next/scmi
head:   1e7cbfaa66d39e78bd24df0c78b55df68176b59e
commit: 46abe13b5e3db187e52cd0de06c07bbce010726c [23/24] firmware: arm_scmi: Add virtio transport
:::::: branch date: 2 days ago
:::::: commit date: 2 days ago

 virtio.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/firmware/arm_scmi/virtio.c
+++ b/drivers/firmware/arm_scmi/virtio.c
@@ -222,7 +222,7 @@ static bool virtio_chan_available(struct
 		return false;
 	}
 
-	return vioch && !vioch->cinfo ? true : false;
+	return vioch && !vioch->cinfo;
 }
 
 static int virtio_chan_setup(struct scmi_chan_info *cinfo, struct device *dev,