linux-kernel - Re: [PATCH v2 3/4] ipack: tpci200: change pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 10 Aug 2021 05:23:52 +0800
From:   kernel test robot <lkp@...el.com>
To:     Dongliang Mu <mudongliangabcd@...il.com>,
        Samuel Iglesias Gonsalvez <siglesias@...lia.com>,
        Jens Taprogge <jens.taprogge@...rogge.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Randy Dunlap <rdunlap@...radead.org>,
        Lv Yunlong <lyl2019@...l.ustc.edu.cn>,
        Aditya Srivastava <yashsri421@...il.com>
Cc:     kbuild-all@...ts.01.org, industrypack-devel@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/4] ipack: tpci200: change pci_iounmap to iounmap

Hi Dongliang,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.14-rc5 next-20210809]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Dongliang-Mu/ipack-tpci200-fix-many-double-free-issues-in-tpci200_pci_probe/20210809-223416
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 36a21d51725af2ce0700c6ebcb6b9594aac658a6
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/aab1c45ab3f37910ebb6f00f951c74ee88e25094
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Dongliang-Mu/ipack-tpci200-fix-many-double-free-issues-in-tpci200_pci_probe/20210809-223416
        git checkout aab1c45ab3f37910ebb6f00f951c74ee88e25094
        # save the attached .config to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross O=build_dir ARCH=ia64 SHELL=/bin/bash drivers/ipack/carriers/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   In file included from include/linux/io.h:13,
                    from include/linux/irq.h:20,
                    from arch/ia64/include/asm/hardirq.h:19,
                    from include/linux/hardirq.h:11,
                    from include/linux/interrupt.h:11,
                    from include/linux/pci.h:38,
                    from drivers/ipack/carriers/tpci200.h:14,
                    from drivers/ipack/carriers/tpci200.c:12:
   drivers/ipack/carriers/tpci200.c: In function 'tpci200_unregister':
>> arch/ia64/include/asm/io.h:268:17: error: too many arguments to function 'iounmap'
     268 | #define iounmap iounmap
         |                 ^~~~~~~
   drivers/ipack/carriers/tpci200.c:91:2: note: in expansion of macro 'iounmap'
      91 |  iounmap(tpci200->info->pdev, tpci200->info->interface_regs);
         |  ^~~~~~~
   arch/ia64/include/asm/io.h:260:13: note: declared here
     260 | extern void iounmap (volatile void __iomem *addr);
         |             ^~~~~~~


vim +/iounmap +268 arch/ia64/include/asm/io.h

ffc45571dfb4b7 include/asm-ia64/io.h      Aron Griffis      2006-10-17  257  
e9b0a0712148ab include/asm-ia64/io.h      Bjorn Helgaas     2006-03-26  258  extern void __iomem * ioremap(unsigned long offset, unsigned long size);
fded1829a24b34 arch/ia64/include/asm/io.h Christoph Hellwig 2019-08-11  259  extern void __iomem * ioremap_uc(unsigned long offset, unsigned long size);
9b50ffb0c0281b include/asm-ia64/io.h      Bjorn Helgaas     2007-03-30  260  extern void iounmap (volatile void __iomem *addr);
6d5bbf00d251cc arch/ia64/include/asm/io.h Len Brown         2011-01-07  261  static inline void __iomem * ioremap_cache (unsigned long phys_addr, unsigned long size)
6d5bbf00d251cc arch/ia64/include/asm/io.h Len Brown         2011-01-07  262  {
6d5bbf00d251cc arch/ia64/include/asm/io.h Len Brown         2011-01-07  263  	return ioremap(phys_addr, size);
6d5bbf00d251cc arch/ia64/include/asm/io.h Len Brown         2011-01-07  264  }
0bbf47eab46975 arch/ia64/include/asm/io.h Arnd Bergmann     2018-07-25  265  #define ioremap ioremap
92281dee825f6d arch/ia64/include/asm/io.h Dan Williams      2015-08-10  266  #define ioremap_cache ioremap_cache
fded1829a24b34 arch/ia64/include/asm/io.h Christoph Hellwig 2019-08-11  267  #define ioremap_uc ioremap_uc
0bbf47eab46975 arch/ia64/include/asm/io.h Arnd Bergmann     2018-07-25 @268  #define iounmap iounmap
^1da177e4c3f41 include/asm-ia64/io.h      Linus Torvalds    2005-04-16  269  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (64473 bytes)