linux-kernel - Re: [PATCH v2 3/4] ipack: tpci200: change pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VeO31R+oYSwoFLnxtz8naK+9OrDgHagVGLrv7ARJjWfwg@mail.gmail.com>
Date:   Mon, 9 Aug 2021 21:29:30 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Dongliang Mu <mudongliangabcd@...il.com>
Cc:     Samuel Iglesias Gonsalvez <siglesias@...lia.com>,
        Jens Taprogge <jens.taprogge@...rogge.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Randy Dunlap <rdunlap@...radead.org>,
        Lv Yunlong <lyl2019@...l.ustc.edu.cn>,
        Aditya Srivastava <yashsri421@...il.com>,
        industrypack-devel@...ts.sourceforge.net,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 3/4] ipack: tpci200: change pci_iounmap to iounmap

On Mon, Aug 9, 2021 at 5:42 PM Dongliang Mu <mudongliangabcd@...il.com> wrote:
>
> The deallocation api for ioremap should be iounmap, other than

API
ioremap()
iounmap()

> pci_iounmap.

pci_iounmap()

Since you haven't compiled this, for the next version consider to
switch to devm_*() and pcim_*() APIs.

-- 
With Best Regards,
Andy Shevchenko