linux-kernel - Re: [PATCH v4 2/2] blk-zoned: allow BLKREPORTZONE without CAP_SYS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YRD9x3+DOTFK82pr@x1-carbon>
Date:   Mon, 9 Aug 2021 10:04:56 +0000
From:   Niklas Cassel <Niklas.Cassel@....com>
To:     Johannes Thumshirn <Johannes.Thumshirn@....com>
CC:     Jens Axboe <axboe@...nel.dk>,
        Damien Le Moal <Damien.LeMoal@....com>,
        Hannes Reinecke <hare@...e.com>,
        Shaun Tancheff <shaun@...cheff.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Damien Le Moal <damien.lemoal@...com>,
        Aravind Ramesh <Aravind.Ramesh@....com>,
        Adam Manzanares <a.manzanares@...sung.com>,
        Himanshu Madhani <himanshu.madhani@...cle.com>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        Jens Axboe <axboe@...com>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 2/2] blk-zoned: allow BLKREPORTZONE without
 CAP_SYS_ADMIN

On Mon, Aug 09, 2021 at 09:58:17AM +0000, Johannes Thumshirn wrote:
> On 09/08/2021 11:50, Niklas Cassel wrote:
> > From: Niklas Cassel <niklas.cassel@....com>
> > 
> > A user space process should not need the CAP_SYS_ADMIN capability set
> > in order to perform a BLKREPORTZONE ioctl.
> > 
> > Getting the zone report is required in order to get the write pointer.
> > Neither read() nor write() requires CAP_SYS_ADMIN, so it is reasonable
> > that a user space process that can read/write from/to the device, also
> > can get the write pointer. (Since e.g. writes have to be at the write
> > pointer.)
> > 
> > Fixes: 3ed05a987e0f ("blk-zoned: implement ioctls")
> > Signed-off-by: Niklas Cassel <niklas.cassel@....com>
> > Reviewed-by: Damien Le Moal <damien.lemoal@...com>
> Nit: Missing 'w'

Seems like Damien's email had a typo in his original reply:

https://patchwork.kernel.org/project/linux-block/patch/20210614122303.154378-3-Niklas.Cassel@wdc.com/#24252237

Surprised that he doesn't have a shortcut to paste his Reviewed-by tag,
considering the amount of patches that he reviews :)

> > Reviewed-by: Aravind Ramesh <aravind.ramesh@....com>
> > Reviewed-by: Adam Manzanares <a.manzanares@...sung.com>
> > Reviewed-by: Himanshu Madhani <himanshu.madhani@...cle.com>
> > Cc: stable@...r.kernel.org # v4.10+
> > ---
> Looks good,
> Reviewed-by: Johannes Thumshirn <johannes.thumshirn@....com>
> 
>