linux-kernel - Re: [PATCH v1 1/2] net: mdio: Add the reset function for IPQ MDIO driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <403a4418-88b4-eb4e-47fd-d75bf6cdccf2@codeaurora.org>
Date:   Mon, 9 Aug 2021 21:02:55 +0800
From:   Jie Luo <luoj@...eaurora.org>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     hkallweit1@...il.com, davem@...emloft.net, kuba@...nel.org,
        linux@...linux.org.uk, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, sricharan@...eaurora.org
Subject: Re: [PATCH v1 1/2] net: mdio: Add the reset function for IPQ MDIO
 driver


On 8/8/2021 11:29 PM, Andrew Lunn wrote:
>> +	/* Configure MDIO clock source frequency if clock is specified in the device tree */
>> +	if (!IS_ERR_OR_NULL(priv->mdio_clk)) {
> Please document the clock in the binding. Make it clear which devices
> require the clock, and which don't.
>
> 	Andrew
sure, will document it in the next patch set, thanks Andrew.