linux-kernel - Re: [PATCH 4/5] ARM: Add basic support for EcoNet EN7523 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c9ec706f-4a55-a716-ed2e-5c04a6f6bffd@biot.com>
Date:   Mon, 9 Aug 2021 15:00:12 +0200
From:   Bert Vermeulen <bert@...t.com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Arnd Bergmann <arnd@...db.de>, DTML <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Russell King <linux@...linux.org.uk>,
        Linus Walleij <linus.walleij@...aro.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Anshuman Khandual <anshuman.khandual@....com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
        John Crispin <john@...ozen.org>,
        Ard Biesheuvel <ardb@...nel.org>,
        YiFei Zhu <yifeifz2@...inois.edu>,
        Mike Rapoport <rppt@...nel.org>,
        Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Kees Cook <keescook@...omium.org>,
        Masahiro Yamada <masahiroy@...nel.org>,
        Nathan Chancellor <nathan@...nel.org>,
        Viresh Kumar <viresh.kumar@...aro.org>,
        Felix Fietkau <nbd@....name>
Subject: Re: [PATCH 4/5] ARM: Add basic support for EcoNet EN7523 SoC

On 8/9/21 2:46 PM, Geert Uytterhoeven wrote:
>> I didn't make that patch, but it turns out it's needed to get PSCI working;
>> detection hangs without it. That makes no sense to me, but I'll examine further.
> 
> Probably PSCI relies on the memory contents at the start of RAM not
> being overwritten?

It turns out to hang at the first SMC call, for PSCI_0_2_FN_PSCI_VERSION. I 
assume the receiver of that call, ATF, got dropped in that region by the 
vendor's U-Boot.

> Does it help if you remove the first 512 KiB from the /memory node
> (which should be declared in en7523-evb.dts instead of en7523.dtsi
> BTW)?
No it doesn't, was just trying to work out why not, in your 
fdt_check_mem_start().

Anyway that was Arnd's first suggestion, but I think his second suggestion 
(teach fdt_check_mem_start() about /memreserve/) is the cleaner approach to 
this. Opinions?


-- 
Bert Vermeulen
bert@...t.com