linux-kernel - Re: [PATCH] locking/rtmutex: Add the missing 'ES' of macro CONFIG_DEBUG_RT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210809144107.GA1458@willie-the-truck>
Date:   Mon, 9 Aug 2021 15:41:07 +0100
From:   Will Deacon <will@...nel.org>
To:     Zhen Lei <thunder.leizhen@...wei.com>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Waiman Long <longman@...hat.com>,
        Boqun Feng <boqun.feng@...il.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] locking/rtmutex: Add the missing 'ES' of macro
 CONFIG_DEBUG_RT_MUTEXES

On Sat, Jul 31, 2021 at 08:30:11PM +0800, Zhen Lei wrote:
> The build option name is defined as DEBUG_RT_MUTEXES in lib/Kconfig.debug,
> commit f41dcc18698e ("locking/rtmutex: Move debug functions as inlines
> into common header") can also corroborate this.
> 
> Fixes: f7efc4799f81 ("locking/rtmutex: Inline chainwalk depth check")
> Signed-off-by: Zhen Lei <thunder.leizhen@...wei.com>
> ---
>  kernel/locking/rtmutex.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/locking/rtmutex.c b/kernel/locking/rtmutex.c
> index b5d9bb5202c6..ad0db322ed3b 100644
> --- a/kernel/locking/rtmutex.c
> +++ b/kernel/locking/rtmutex.c
> @@ -343,7 +343,7 @@ static __always_inline bool
>  rt_mutex_cond_detect_deadlock(struct rt_mutex_waiter *waiter,
>  			      enum rtmutex_chainwalk chwalk)
>  {
> -	if (IS_ENABLED(CONFIG_DEBUG_RT_MUTEX))
> +	if (IS_ENABLED(CONFIG_DEBUG_RT_MUTEXES))
>  		return waiter != NULL;
>  	return chwalk == RT_MUTEX_FULL_CHAINWALK;

Oops, yes. How did you find this?

Acked-by: Will Deacon <will@...nel.org>

Will