linux-kernel - Re: [PATCH 03/17] staging: r8188eu: remove unnecessary parentheses in core/rtw_mlme

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 9 Aug 2021 17:55:43 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Michael Straube <straube.linux@...il.com>
Cc:     gregkh@...uxfoundation.org, Larry.Finger@...inger.net,
        phil@...lpotter.co.uk, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 03/17] staging: r8188eu: remove unnecessary parentheses
 in core/rtw_mlme_ext.c

On Sat, Aug 07, 2021 at 12:11:05PM +0200, Michael Straube wrote:
> @@ -1855,12 +1855,12 @@ void issue_p2p_GO_request(struct adapter *padapter, u8 *raddr)
>  	pframe += sizeof(struct rtw_ieee80211_hdr_3addr);
>  	pattrib->pktlen = sizeof(struct rtw_ieee80211_hdr_3addr);
>  
> -	pframe = rtw_set_fixed_ie(pframe, 1, &(category), &(pattrib->pktlen));
> -	pframe = rtw_set_fixed_ie(pframe, 1, &(action), &(pattrib->pktlen));
> -	pframe = rtw_set_fixed_ie(pframe, 4, (unsigned char *)&(p2poui), &(pattrib->pktlen));
> -	pframe = rtw_set_fixed_ie(pframe, 1, &(oui_subtype), &(pattrib->pktlen));
> +	pframe = rtw_set_fixed_ie(pframe, 1, &(category), &pattrib->pktlen);
                                             ^^^^^^^^^^^
These should be removed as well.

> +	pframe = rtw_set_fixed_ie(pframe, 1, &(action), &pattrib->pktlen);
                                             ^^^^^^^^
> +	pframe = rtw_set_fixed_ie(pframe, 4, (unsigned char *)&(p2poui), &pattrib->pktlen);
> +	pframe = rtw_set_fixed_ie(pframe, 1, &(oui_subtype), &pattrib->pktlen);
                                             ^^^^^^^^^^^^^^

All the third parameters of rtw_set_fixed_ie() in this patch really.

>  	pwdinfo->negotiation_dialog_token = 1;	/*	Initialize the dialog value */
> -	pframe = rtw_set_fixed_ie(pframe, 1, &pwdinfo->negotiation_dialog_token, &(pattrib->pktlen));
> +	pframe = rtw_set_fixed_ie(pframe, 1, &pwdinfo->negotiation_dialog_token, &pattrib->pktlen);
>  
>  	/*	WPS Section */
>  	wpsielen = 0;

regards,
dan carpenter