linux-kernel - Re: [PATCH 07/17] staging: r8188eu: remove unnecessary parentheses in core/rtw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210809145722.GS1931@kadam>
Date:   Mon, 9 Aug 2021 17:57:23 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Michael Straube <straube.linux@...il.com>
Cc:     gregkh@...uxfoundation.org, Larry.Finger@...inger.net,
        phil@...lpotter.co.uk, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 07/17] staging: r8188eu: remove unnecessary parentheses
 in core/rtw_p2p.c

On Sat, Aug 07, 2021 at 12:11:09PM +0200, Michael Straube wrote:
> @@ -155,10 +155,10 @@ static void issue_group_disc_req(struct wifidirect_info *pwdinfo, u8 *da)
>  	pattrib->pktlen = sizeof(struct rtw_ieee80211_hdr_3addr);
>  
>  	/* Build P2P action frame header */
> -	pframe = rtw_set_fixed_ie(pframe, 1, &(category), &(pattrib->pktlen));
> -	pframe = rtw_set_fixed_ie(pframe, 4, (unsigned char *)&(p2poui), &(pattrib->pktlen));
> -	pframe = rtw_set_fixed_ie(pframe, 1, &(oui_subtype), &(pattrib->pktlen));
> -	pframe = rtw_set_fixed_ie(pframe, 1, &(dialogToken), &(pattrib->pktlen));
> +	pframe = rtw_set_fixed_ie(pframe, 1, &(category), &pattrib->pktlen);
> +	pframe = rtw_set_fixed_ie(pframe, 4, (unsigned char *)&(p2poui), &pattrib->pktlen);
> +	pframe = rtw_set_fixed_ie(pframe, 1, &(oui_subtype), &pattrib->pktlen);
> +	pframe = rtw_set_fixed_ie(pframe, 1, &(dialogToken), &pattrib->pktlen);

Same thing as the earlier patch.  Only the fourth parameter is fixed and
not the others.

regards,
dan carpenter