linux-kernel - Re: [PATCH v5 3/5] iio: adc: ad7949: add support for internal vref

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Ve6Csjeeh7+ti6UE0-YPRHHFHXFA3jQwp+bqTAfL50_ig@mail.gmail.com>
Date:   Tue, 10 Aug 2021 22:55:42 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Liam Beguin <liambeguin@...il.com>
Cc:     Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Michael Hennerich <Michael.Hennerich@...log.com>,
        Charles-Antoine Couret <charles-antoine.couret@...ensium.com>,
        Nuno Sá <Nuno.Sa@...log.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-iio <linux-iio@...r.kernel.org>,
        devicetree <devicetree@...r.kernel.org>,
        Rob Herring <robh+dt@...nel.org>
Subject: Re: [PATCH v5 3/5] iio: adc: ad7949: add support for internal vref

On Tue, Aug 10, 2021 at 10:46 PM Liam Beguin <liambeguin@...il.com> wrote:
> On Tue Aug 10, 2021 at 8:15 AM EDT, Andy Shevchenko wrote:
> > On Mon, Aug 9, 2021 at 1:50 AM Liam Beguin <liambeguin@...il.com> wrote:
> > > On Sun Aug 8, 2021 at 12:36 PM EDT, Jonathan Cameron wrote:
> > > > On Sat, 7 Aug 2021 21:56:57 -0400
> > >         ret = fwnode_property_read_u32(child, "adi,internal-ref-microvolt", &tmp);
> > >         if (ret == -EINVAL && mode & AD7949_CFG_VAL_REF_EXTERNAL) {
> > >                 continue;
> >
> > >         } else if (ret < 0) {

> > Side note, redundant 'else'
>
> Are you asking to add an 'else' statement?
>
> because, unless I'm mistaken, in this case ret can have other negative values
> that we want to catch with this 'else if'.

You lost me, I have no idea what "to add" and "other" mean here. No, I
asked to remove it. It's redundant.

> > >                 dev_err(dev, "invalid voltage reference in %pfw\n", child);
> > >                 fwnode_handle_put(child);
> > >                 return ret;
> > >         }

-- 
With Best Regards,
Andy Shevchenko