linux-kernel - Re: [PATCH v5 3/5] iio: adc: ad7949: add support for internal vref

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <CDG3ATRV00VV.57ZPL3OPU5N4@shaak>
Date:   Tue, 10 Aug 2021 15:46:16 -0400
From:   "Liam Beguin" <liambeguin@...il.com>
To:     "Andy Shevchenko" <andy.shevchenko@...il.com>
Cc:     "Jonathan Cameron" <jic23@...nel.org>, <lars@...afoo.de>,
        <Michael.Hennerich@...log.com>,
        <charles-antoine.couret@...ensium.com>, <Nuno.Sa@...log.com>,
        <linux-kernel@...r.kernel.org>, <linux-iio@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <robh+dt@...nel.org>
Subject: Re: [PATCH v5 3/5] iio: adc: ad7949: add support for internal vref

On Tue Aug 10, 2021 at 8:15 AM EDT, Andy Shevchenko wrote:
> On Mon, Aug 9, 2021 at 1:50 AM Liam Beguin <liambeguin@...il.com> wrote:
> > On Sun Aug 8, 2021 at 12:36 PM EDT, Jonathan Cameron wrote:
> > > On Sat, 7 Aug 2021 21:56:57 -0400
> >         ret = fwnode_property_read_u32(child, "adi,internal-ref-microvolt", &tmp);
> >         if (ret == -EINVAL && mode & AD7949_CFG_VAL_REF_EXTERNAL) {
> >                 continue;
>
> >         } else if (ret < 0) {
>

Hi Andy,

> Side note, redundant 'else'

Are you asking to add an 'else' statement?

because, unless I'm mistaken, in this case ret can have other negative values
that we want to catch with this 'else if'.

Thanks for your time,
Liam

>
> >                 dev_err(dev, "invalid voltage reference in %pfw\n", child);
> >                 fwnode_handle_put(child);
> >                 return ret;
> >         }
>
>
> --
> With Best Regards,
> Andy Shevchenko