linux-kernel - Re: [PATCH v5 3/5] iio: adc: ad7949: add support for internal vref

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vc3o-RrHD_wt_CfJY3P8hoRhJkdiRRySFS_O_7VdtJTQA@mail.gmail.com>
Date:   Tue, 10 Aug 2021 15:15:36 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Liam Beguin <liambeguin@...il.com>
Cc:     Jonathan Cameron <jic23@...nel.org>, lars@...afoo.de,
        Michael.Hennerich@...log.com, charles-antoine.couret@...ensium.com,
        Nuno.Sa@...log.com, linux-kernel@...r.kernel.org,
        linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
        robh+dt@...nel.org
Subject: Re: [PATCH v5 3/5] iio: adc: ad7949: add support for internal vref

On Mon, Aug 9, 2021 at 1:50 AM Liam Beguin <liambeguin@...il.com> wrote:
> On Sun Aug 8, 2021 at 12:36 PM EDT, Jonathan Cameron wrote:
> > On Sat, 7 Aug 2021 21:56:57 -0400
>         ret = fwnode_property_read_u32(child, "adi,internal-ref-microvolt", &tmp);
>         if (ret == -EINVAL && mode & AD7949_CFG_VAL_REF_EXTERNAL) {
>                 continue;

>         } else if (ret < 0) {

Side note, redundant 'else'

>                 dev_err(dev, "invalid voltage reference in %pfw\n", child);
>                 fwnode_handle_put(child);
>                 return ret;
>         }


-- 
With Best Regards,
Andy Shevchenko