lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 10 Aug 2021 23:50:34 +0100 From: Phillip Potter <phil@...lpotter.co.uk> To: Larry Finger <Larry.Finger@...inger.net> Cc: gregkh@...uxfoundation.org, linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org Subject: Re: [PATCH v2] staging: r8188eu: Replace BITn with BIT(n) On Tue, Aug 10, 2021 at 01:05:11PM -0500, Larry Finger wrote: > The driver uses BITn instead of BIT(n). All such usage is converted. > > Note that this patch does not address any warnings that checkpatch > will find. These include missing space around operators and lines > that are too long. These problems will be addressed in a separate > patch. > > Signed-off-by: Larry Finger <Larry.Finger@...inger.net> > > --- > v2 - Removed dependency on incorrect patch > Fixed typo n comment noted by Dan Carpenter > --- > drivers/staging/r8188eu/core/rtw_ioctl_set.c | 2 +- > drivers/staging/r8188eu/hal/HalPhyRf_8188e.c | 40 +- > drivers/staging/r8188eu/hal/odm.c | 68 +-- > drivers/staging/r8188eu/hal/odm_HWConfig.c | 4 +- > drivers/staging/r8188eu/hal/odm_RTL8188E.c | 116 ++--- > drivers/staging/r8188eu/hal/rtl8188e_cmd.c | 14 +- > .../staging/r8188eu/hal/rtl8188e_hal_init.c | 66 +-- > drivers/staging/r8188eu/hal/rtl8188e_mp.c | 34 +- > drivers/staging/r8188eu/hal/rtl8188e_phycfg.c | 8 +- > drivers/staging/r8188eu/hal/rtl8188eu_led.c | 10 +- > drivers/staging/r8188eu/hal/usb_halinit.c | 48 +- > .../staging/r8188eu/include/Hal8188EPhyCfg.h | 14 +- > .../staging/r8188eu/include/Hal8188EPwrSeq.h | 84 ++-- > drivers/staging/r8188eu/include/hal_intf.h | 16 +- > drivers/staging/r8188eu/include/odm.h | 106 ++--- > drivers/staging/r8188eu/include/odm_reg.h | 2 +- > drivers/staging/r8188eu/include/odm_types.h | 8 +- > .../staging/r8188eu/include/osdep_service.h | 42 -- > .../staging/r8188eu/include/rtl8188e_spec.h | 415 ++++++++---------- > drivers/staging/r8188eu/include/rtw_sreset.h | 14 +- > drivers/staging/r8188eu/os_dep/ioctl_linux.c | 4 +- > 21 files changed, 518 insertions(+), 597 deletions(-) > Dear Larry, Looks good and builds fine for me. Acked-by: Phillip Potter <phil@...lpotter.co.uk> Regards, Phil
Powered by blists - more mailing lists