lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 10 Aug 2021 11:59:39 +0200 From: Daniel Vetter <daniel@...ll.ch> To: zhaoxiao <zhaoxiao@...ontech.com> Cc: robdclark@...il.com, sean@...rly.run, airlied@...ux.ie, daniel@...ll.ch, linux-arm-msm@...r.kernel.org, dri-devel@...ts.freedesktop.org, freedreno@...ts.freedesktop.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v2] drm/drv: Remove initialization of static variables On Fri, Aug 06, 2021 at 10:30:47AM +0800, zhaoxiao wrote: > Address the following checkpatch errors: > ERROR: do not initialise statics to false > > FILE: :drivers/gpu/drm/msm/msm_drv.c:21: > -static bool reglog = false; > > FILE: :drivers/gpu/drm/msm/msm_drv.c:31: > -bool dumpstate = false; > > Signed-off-by: zhaoxiao <zhaoxiao@...ontech.com> Subject should start out with drm/msm, not drm/drv - that would indicate a patch touching the drm_drv.c core files, or things related to that. -Daniel > --- > v2: change the patch description > drivers/gpu/drm/msm/msm_drv.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c > index 9b8fa2ad0d84..d9ca4bc9620b 100644 > --- a/drivers/gpu/drm/msm/msm_drv.c > +++ b/drivers/gpu/drm/msm/msm_drv.c > @@ -59,7 +59,7 @@ static const struct drm_mode_config_helper_funcs mode_config_helper_funcs = { > }; > > #ifdef CONFIG_DRM_MSM_REGISTER_LOGGING > -static bool reglog = false; > +static bool reglog; > MODULE_PARM_DESC(reglog, "Enable register read/write logging"); > module_param(reglog, bool, 0600); > #else > @@ -76,7 +76,7 @@ static char *vram = "16m"; > MODULE_PARM_DESC(vram, "Configure VRAM size (for devices without IOMMU/GPUMMU)"); > module_param(vram, charp, 0); > > -bool dumpstate = false; > +bool dumpstate; > MODULE_PARM_DESC(dumpstate, "Dump KMS state on errors"); > module_param(dumpstate, bool, 0600); > > -- > 2.20.1 > > > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
Powered by blists - more mailing lists