linux-kernel - Re: [PATCH] fix UBSAN splat in test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 10 Aug 2021 09:37:01 -0400
From:   Christoph von Recklinghausen <crecklin@...hat.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     pmladek@...e.com, rostedt@...dmis.org, senozhatsky@...omium.org,
        linux@...musvillemoes.dk, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fix UBSAN splat in test_scanf


On 8/10/21 9:31 AM, Andy Shevchenko wrote:
> On Mon, Aug 09, 2021 at 06:20:13AM -0400, Chris von Recklinghausen wrote:
>
> Thanks for the report and fix!
>
> First of all, have you seen this:
> https://lore.kernel.org/lkml/20210727150132.28920-1-andriy.shevchenko@linux.intel.com/T/#u
> ?


No I hadn't seen it. I'll defer to this fix then.

Thanks,

Chris


>
>> On a system with CONFIG_UBSAN_SHIFT=y, the following splat was observed:
>> [  104.676826] test_scanf: loaded.
>> [  104.680862] ================================================================================
>> [  104.690304] UBSAN: shift-out-of-bounds in lib/test_scanf.c:274:51
>> [  104.697144] shift exponent 32 is too large for 32-bit type 'unsigned int'
> As you may see in the above the rule of thumb is to include only meaningful
> parts of the oops.
>