linux-kernel - [BUG] scsi: iscsi: possible null-pointer dereference in iscsit_tpg_add_network

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Tue, 10 Aug 2021 21:48:03 +0800
From:   Tuo Li <islituo@...il.com>
To:     martin.petersen@...cle.com
Cc:     baijiaju1990@...il.com, linux-scsi@...r.kernel.org,
        target-devel@...r.kernel.org,
        Linux Kernel <linux-kernel@...r.kernel.org>
Subject: [BUG] scsi: iscsi: possible null-pointer dereference in
 iscsit_tpg_add_network_portal()

Hello,

Our static analysis tool finds a possible null-pointer dereference in 
the iscsi driver in Linux 5.14.0-rc3:

The variable tpg->tpg_tiqn is checked in:
496:    if (tpg->tpg_tiqn)

This indicates that it can be NULL. If so, a null-pointer dereference 
will occur:
508:    pr_debug("CORE[%s] - Added Network Portal: %pISpc,%hu on %s\n", 
tpg->tpg_tiqn->tiqn, ...)

I am not quite sure whether this possible null-pointer dereference is 
real and how to fix it if it is real.
Any feedback would be appreciated, thanks!

Reported-by: TOTE Robot <oslab@...nghua.edu.cn>

Best wishes,
Tuo Li