linux-kernel - Re: [RFC PATCH v2 01/10] docs: Add block device LED trigger documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210810134904.GA28089@amd>
Date:   Tue, 10 Aug 2021 15:49:04 +0200
From:   Pavel Machek <pavel@....cz>
To:     Ian Pilcher <arequipeno@...il.com>
Cc:     linux-block@...r.kernel.org, linux-leds@...r.kernel.org,
        axboe@...nel.dk, linux-kernel@...r.kernel.org,
        kernelnewbies@...nelnewbies.org
Subject: Re: [RFC PATCH v2 01/10] docs: Add block device LED trigger
 documentation

Hi!

> +++ b/Documentation/ABI/testing/sysfs-block
> @@ -316,3 +316,19 @@ Description:
>  		does not complete in this time then the block driver timeout
>  		handler is invoked. That timeout handler can decide to retry
>  		the request, to fail it or to start a device recovery strategy.
> +
> +What:		/sys/block/<disk>/led
> +Date:		August 2021
> +Contact:	Ian Pilcher <arequipeno@...il.com>
> +Description:
> +		Set the LED associated with this block device (or show available
> +		LEDs and the currently selected LED, if any).
> +
> +		Reading the attribute will display the available LEDs (LEDs that
> +		are associated with the blkdev LED trigger).  The currently
> +		selected LED is enclosed in square brackets.  To clear the
> +		device's LED association write 'none' (without the quotes) or
> +		an empty string/line to the attribute.
> +
> +		See Documentation/ABI/testing/sysfs-class-led-trigger-blkdev and
> +		Documentation/block/blk-ledtrig.rst.)

I have to agree with Marek / Pali -- this is very strange interface.

Best regards,
								Pavel
-- 
http://www.livejournal.com/~pavelmachek

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)