linux-kernel - Re: [PATCH] bus: ti-sysc: Fix error handling for sysc_check_active

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210811062231.GA16241@duo.ucw.cz>
Date:   Wed, 11 Aug 2021 08:22:31 +0200
From:   Pavel Machek <pavel@...x.de>
To:     Tony Lindgren <tony@...mide.com>
Cc:     linux-omap@...r.kernel.org, Dave Gerlach <d-gerlach@...com>,
        Faiz Abbas <faiz_abbas@...com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Grygorii Strashko <grygorii.strashko@...com>,
        Keerthy <j-keerthy@...com>, Nishanth Menon <nm@...com>,
        Suman Anna <s-anna@...com>, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, Pavel Machek <pavel@...x.de>,
        Jarkko Nikula <jarkko.nikula@...mer.com>
Subject: Re: [PATCH] bus: ti-sysc: Fix error handling for
 sysc_check_active_timer()

On Wed 2021-08-11 09:10:53, Tony Lindgren wrote:
> We have changed the return type for sysc_check_active_timer() from -EBUSY
> to -ENXIO, but the gpt12 system timer fix still checks for -EBUSY. We are
> also not returning on other errors like we did earlier as noted by
> Pavel Machek <pavel@...x.de>.
> 
> Commit 3ff340e24c9d ("bus: ti-sysc: Fix gpt12 system timer issue with
> reserved status") should have been updated for commit 65fb73676112
> ("bus: ti-sysc: suppress err msg for timers used as clockevent/source").
> 
> Let's fix the issue by checking for -ENXIO and returning on any other
> errors as suggested by Pavel Machek <pavel@...x.de>.
> 
> Fixes: 3ff340e24c9d ("bus: ti-sysc: Fix gpt12 system timer issue with reserved status")
> Depends-on: 65fb73676112 ("bus: ti-sysc: suppress err msg for timers used as clockevent/source")
> Reported-by: Pavel Machek <pavel@...x.de>
> Cc: Grygorii Strashko <grygorii.strashko@...com>
> Cc: Jarkko Nikula <jarkko.nikula@...mer.com>
> Signed-off-by: Tony Lindgren <tony@...mide.com>

Reviewed-by: Pavel Machek (CIP) <pavel@...x.de>

Best regards,
								Pavel
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)