linux-kernel - Re: [PATCH] bus: ti-sysc: Fix error handling for sysc_check_active

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d9ebbc7f-07f1-160f-f463-7c54ed8dd6d7@bitmer.com>
Date:   Sun, 15 Aug 2021 21:05:04 +0300
From:   Jarkko Nikula <jarkko.nikula@...mer.com>
To:     Pavel Machek <pavel@...x.de>, Tony Lindgren <tony@...mide.com>
Cc:     linux-omap@...r.kernel.org, Dave Gerlach <d-gerlach@...com>,
        Faiz Abbas <faiz_abbas@...com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Grygorii Strashko <grygorii.strashko@...com>,
        Keerthy <j-keerthy@...com>, Nishanth Menon <nm@...com>,
        Suman Anna <s-anna@...com>, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] bus: ti-sysc: Fix error handling for
 sysc_check_active_timer()

Hi

On 8/11/21 9:22 AM, Pavel Machek wrote:
> On Wed 2021-08-11 09:10:53, Tony Lindgren wrote:
>> We have changed the return type for sysc_check_active_timer() from -EBUSY
>> to -ENXIO, but the gpt12 system timer fix still checks for -EBUSY. We are
>> also not returning on other errors like we did earlier as noted by
>> Pavel Machek <pavel@...x.de>.
>>
>> Commit 3ff340e24c9d ("bus: ti-sysc: Fix gpt12 system timer issue with
>> reserved status") should have been updated for commit 65fb73676112
>> ("bus: ti-sysc: suppress err msg for timers used as clockevent/source").
>>
>> Let's fix the issue by checking for -ENXIO and returning on any other
>> errors as suggested by Pavel Machek <pavel@...x.de>.
>>
>> Fixes: 3ff340e24c9d ("bus: ti-sysc: Fix gpt12 system timer issue with reserved status")
>> Depends-on: 65fb73676112 ("bus: ti-sysc: suppress err msg for timers used as clockevent/source")
>> Reported-by: Pavel Machek <pavel@...x.de>
>> Cc: Grygorii Strashko <grygorii.strashko@...com>
>> Cc: Jarkko Nikula <jarkko.nikula@...mer.com>
>> Signed-off-by: Tony Lindgren <tony@...mide.com>
> 
> Reviewed-by: Pavel Machek (CIP) <pavel@...x.de>
> 
I double checked but actually both plain 0aa78d17099b ("Merge tag
'scsi-fixes' of
git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi") and with this
patch boot fine on my Beagle C2.

Anyway,

Tested-by: jarkko.nikula@...mer.com