linux-kernel - Re: [PATCH 8/8] staging: r8188eu: remove lines from Makefile that silence build warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YRN/BYRayELQnM+2@kroah.com>
Date:   Wed, 11 Aug 2021 09:40:53 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Phillip Potter <phil@...lpotter.co.uk>
Cc:     Larry.Finger@...inger.net, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 8/8] staging: r8188eu: remove lines from Makefile that
 silence build warnings

On Wed, Aug 11, 2021 at 12:50:47AM +0100, Phillip Potter wrote:
> Remove the several lines from the Makefile that append EXTRA_CFLAGS options
> to silence build warnings about unused variables, unused functions and such
> like. This will enable cleanup of missed warnings, and easier spotting
> of future such problems.
> 
> Signed-off-by: Phillip Potter <phil@...lpotter.co.uk>
> ---
>  drivers/staging/r8188eu/Makefile | 9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/drivers/staging/r8188eu/Makefile b/drivers/staging/r8188eu/Makefile
> index 152d6325b4d9..7f6658f931d1 100644
> --- a/drivers/staging/r8188eu/Makefile
> +++ b/drivers/staging/r8188eu/Makefile
> @@ -2,15 +2,6 @@ SHELL := /bin/bash
>  EXTRA_CFLAGS += $(USER_EXTRA_CFLAGS)
>  EXTRA_CFLAGS += -O1
>  
> -EXTRA_CFLAGS += -Wno-unused-variable
> -EXTRA_CFLAGS += -Wno-unused-value
> -EXTRA_CFLAGS += -Wno-unused-label
> -EXTRA_CFLAGS += -Wno-unused-parameter
> -EXTRA_CFLAGS += -Wno-unused-function
> -EXTRA_CFLAGS += -Wno-unused
> -
> -EXTRA_CFLAGS += -Wno-uninitialized
> -

Ah, that is why I didn't see any warnings!  Thanks for these changes,
will go queue them up now.

greg k-h