linux-kernel - Re: [PATCH V1 1/4] bindings: nvmem: introduce "reverse-data" property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6d396b18455a228719ac4ffeeddcca20b0aa0184.camel@pengutronix.de>
Date:   Wed, 11 Aug 2021 11:05:38 +0200
From:   Jan Lübbe <jlu@...gutronix.de>
To:     Joakim Zhang <qiangqing.zhang@....com>,
        "srinivas.kandagatla@...aro.org" <srinivas.kandagatla@...aro.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>
Cc:     "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V1 1/4] bindings: nvmem: introduce "reverse-data"
 property

On Wed, 2021-08-11 at 08:06 +0000, Joakim Zhang wrote:
> 
> > -----Original Message-----
> > From: Joakim Zhang <qiangqing.zhang@....com>
> > Sent: 2021年8月11日 16:05
> > To: Jan Lübbe <jlu@...gutronix.de>; srinivas.kandagatla@...aro.org;
> > robh+dt@...nel.org; shawnguo@...nel.org
> > Cc: devicetree@...r.kernel.org; dl-linux-imx <linux-imx@....com>;
> > kernel@...gutronix.de; linux-kernel@...r.kernel.org
> > Subject: RE: [PATCH V1 1/4] bindings: nvmem: introduce "reverse-data"
> > property
> > 
> > 
> > > -----Original Message-----
> > > From: Jan Lübbe <jlu@...gutronix.de>
> > > Sent: 2021年8月10日 23:14
> > > To: Joakim Zhang <qiangqing.zhang@....com>;
> > > srinivas.kandagatla@...aro.org; robh+dt@...nel.org;
> > > shawnguo@...nel.org
> > > Cc: devicetree@...r.kernel.org; dl-linux-imx <linux-imx@....com>;
> > > kernel@...gutronix.de; linux-kernel@...r.kernel.org
> > > Subject: Re: [PATCH V1 1/4] bindings: nvmem: introduce "reverse-data"
> > > property
> > > 
> > > On Tue, 2021-08-10 at 15:35 +0800, Joakim Zhang wrote:
> > > > Introduce "reverse-data" property for nvmem provider to reverse buffer.
> > > > 
> > > > Signed-off-by: Joakim Zhang <qiangqing.zhang@....com>
> > > > ---
> > > >  Documentation/devicetree/bindings/nvmem/nvmem.yaml | 5 +++++
> > > >  1 file changed, 5 insertions(+)
> > > > 
> > > > diff --git a/Documentation/devicetree/bindings/nvmem/nvmem.yaml
> > > > b/Documentation/devicetree/bindings/nvmem/nvmem.yaml
> > > > index b8dc3d2b6e92..bc745083fc64 100644
> > > > --- a/Documentation/devicetree/bindings/nvmem/nvmem.yaml
> > > > +++ b/Documentation/devicetree/bindings/nvmem/nvmem.yaml
> > > > @@ -61,6 +61,11 @@ patternProperties:
> > > >                description:
> > > >                  Size in bit within the address range specified by reg.
> > > > 
> > > > +      reverse-data:
> > > > +        $ref: /schemas/types.yaml#/definitions/flag
> > > > +        description:
> > > > +          Reverse the data that read from the storage device.
> > > 
> > > I'd prefer if it was more explicit that the *bytes* will be reversed.
> > > Otherwise a reader might think that this is reversing on the *bit* level.
> > 
> > Make sense, how about 'reverse-byte-order'?
> 
> Sorry, 'reverse-bytes-order'.

'reverse-byte-order' sounds better to me, but I'm not a native English speaker.
I'd be fine with either, though.

Thanks
Jan