linux-kernel - Re: [PATCH] memblock: Add missing debug code to memblock_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3d2ce3dd-5032-89fc-822d-5288a9c460b9@redhat.com>
Date:   Wed, 11 Aug 2021 11:36:03 +0200
From:   David Hildenbrand <david@...hat.com>
To:     Geert Uytterhoeven <geert+renesas@...der.be>,
        Mike Rapoport <rppt@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] memblock: Add missing debug code to memblock_add_node()

On 11.08.21 10:54, Geert Uytterhoeven wrote:
> All other memblock APIs built on top of memblock_add_range() contain
> debug code to print their parameters.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> ---
>   mm/memblock.c | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/mm/memblock.c b/mm/memblock.c
> index de7b553baa50004c..57a9849a5d820c34 100644
> --- a/mm/memblock.c
> +++ b/mm/memblock.c
> @@ -665,6 +665,11 @@ static int __init_memblock memblock_add_range(struct memblock_type *type,
>   int __init_memblock memblock_add_node(phys_addr_t base, phys_addr_t size,
>   				       int nid)
>   {
> +	phys_addr_t end = base + size - 1;
> +
> +	memblock_dbg("%s: [%pa-%pa] nid=%d %pS\n", __func__,
> +		     &base, &end, nid, (void *)_RET_IP_);
> +
>   	return memblock_add_range(&memblock.memory, base, size, nid, 0);
>   }
>   
> 

Reviewed-by: David Hildenbrand <david@...hat.com>

-- 
Thanks,

David / dhildenb