linux-kernel - Re: [PATCH] fpga: machxo2-spi: return an error on failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YRO0izb18fMEdxWH@archbook>
Date:   Wed, 11 Aug 2021 04:29:15 -0700
From:   Moritz Fischer <mdf@...nel.org>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Greg KH <gregkh@...uxfoundation.org>, trix@...hat.com,
        mdf@...nel.org, p.pisati@...il.com, atull@...nel.org,
        linux-fpga@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fpga: machxo2-spi: return an error on failure

On Tue, Aug 10, 2021 at 09:51:16PM +0300, Dan Carpenter wrote:
> On Tue, Aug 10, 2021 at 07:06:09PM +0200, Greg KH wrote:
> > On Tue, Aug 10, 2021 at 09:40:36AM -0700, trix@...hat.com wrote:
> > > From: Tom Rix <trix@...hat.com>
> > > 
> > > Reported problem
> > > 
> > > 	drivers/fpga/machxo2-spi.c:229 machxo2_write_init()
> > > 	warn: missing error code 'ret'
> > > 
> > > 	drivers/fpga/machxo2-spi.c:316 machxo2_write_complete()
> > > 	warn: missing error code 'ret'
> > 
> > What reported this?  What does it mean?  Where was it reported?
> 
> These are Smatch errors, but my bug reports don't mention Smatch so
> that's on me.  I've fixed my report templated to mention Smatch now.
> 
> regards,
> dan carepenter
> 
> 
Applied with slightly reworded commit-message to 'fixes' branch.

Thanks,
Moritz