linux-kernel - Re: [PATCH v5 19/19] auxdisplay: ht16k33: Add LED support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdUFPvJBuFByiN6pb539REYtcsNJMKML+M2NQw=GJxTYJg@mail.gmail.com>
Date:   Wed, 11 Aug 2021 13:29:07 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Marek Behún <kabel@...nel.org>
Cc:     Robin van der Gracht <robin@...tonic.nl>,
        Miguel Ojeda <ojeda@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Paul Burton <paulburton@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Pavel Machek <pavel@....cz>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        linux-leds <linux-leds@...r.kernel.org>,
        "open list:BROADCOM NVRAM DRIVER" <linux-mips@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5 19/19] auxdisplay: ht16k33: Add LED support

Hi Marek,

On Wed, Aug 11, 2021 at 12:48 PM Marek Behún <kabel@...nel.org> wrote:
> On Wed, 11 Aug 2021 11:57:59 +0200
> Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
>
> > Instantiate a single LED based on the "led" subnode in DT.
> > This allows the user to control display brightness and blinking (backed
> > by hardware support) through the LED class API and triggers, and exposes
> > the display color.  The LED will be named
> > "auxdisplay:<color>:<function>".
> >
> > When running in dot-matrix mode and if no "led" subnode is found, the
> > driver falls back to the traditional backlight mode, to preserve
> > backwards compatibility.
> >
> > Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
>
> Reviewed-by: Marek Behún <kabel@...nel.org>

Thanks!

> BTW, this driver does not need to depend on OF, methinks.
> The few instances of properties reading can be
> easily rewritten to device_* functions (from include/linux/property.h).
> The of_get_child_by_name() can become device_get_named_child_node().
>
> Geert, what do you think?

Sure, that can be done later, when an ACPI user appears?
The dependency on OF was pre-existing, and this series is already
at v5.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds