linux-kernel - Re: [PATCH 5.13 159/175] interconnect: qcom: icc-rpmh: Add BCMs to commit list in pre

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YRTDcP5Mrf3omdzj@kroah.com>
Date:   Thu, 12 Aug 2021 08:45:04 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Georgi Djakov <djakov@...nel.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Mike Tipton <mdtipton@...eaurora.org>
Subject: Re: [PATCH 5.13 159/175] interconnect: qcom: icc-rpmh: Add BCMs to
 commit list in pre_aggregate

On Wed, Aug 11, 2021 at 06:50:12PM +0300, Georgi Djakov wrote:
> On 10.08.21 20:31, Greg Kroah-Hartman wrote:
> > From: Mike Tipton <mdtipton@...eaurora.org>
> > 
> > commit f84f5b6f72e68bbaeb850b58ac167e4a3a47532a upstream.
> > 
> > We're only adding BCMs to the commit list in aggregate(), but there are
> > cases where pre_aggregate() is called without subsequently calling
> > aggregate(). In particular, in icc_sync_state() when a node with initial
> > BW has zero requests. Since BCMs aren't added to the commit list in
> > these cases, we don't actually send the zero BW request to HW. So the
> > resources remain on unnecessarily.
> > 
> > Add BCMs to the commit list in pre_aggregate() instead, which is always
> > called even when there are no requests.
> > 
> > Fixes: 976daac4a1c5 ("interconnect: qcom: Consolidate interconnect RPMh support")
> > Signed-off-by: Mike Tipton <mdtipton@...eaurora.org>
> > Link: https://lore.kernel.org/r/20210721175432.2119-5-mdtipton@codeaurora.org
> > Signed-off-by: Georgi Djakov <djakov@...nel.org>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> 
> Hello Greg,
> 
> Please drop this patch, as people are reporting issues on some
> platforms. So please do not apply it to any stable trees yet
> (5.10 and 5.13). I will send a revert (or other fix) to you soon.

Now dropped from both queues, thanks.

greg k-h