[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <YRTD3szluseOmv8f@kroah.com>
Date: Thu, 12 Aug 2021 08:46:54 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Slark Xiao <slark_xiao@....com>
Cc: johan@...nel.org, linux-usb@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: Re: [PATCH] [v2,1/1] This aims to support Foxconn SDX55
On Thu, Aug 12, 2021 at 09:52:56AM +0800, Slark Xiao wrote:
> At 2021-08-11 19:42:20, "Greg KH" <gregkh@...uxfoundation.org> wrote:
> >On Wed, Aug 11, 2021 at 04:56:35PM +0800, Slark Xiao wrote:
> >> Foxconn SDX55 T77W175 device is working in PCIe mode normally.
> >> You can find it in drivers/bus/mhi/pci_geneirc.c file.
> >> But in some scenario, we need to capture the memory dump once it crashed.
> >> So a diag port driver is needed.
> >>
> >> Signed-off-by: Slark Xiao <slark_xiao@....com>
> >> ---
> >> drivers/usb/serial/qcserial.c | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >> diff --git a/drivers/usb/serial/qcserial.c b/drivers/usb/serial/qcserial.c
> >> index 83da8236e3c8..d8b58aea3c60 100644
> >> --- a/drivers/usb/serial/qcserial.c
> >> +++ b/drivers/usb/serial/qcserial.c
> >> @@ -111,6 +111,7 @@ static const struct usb_device_id id_table[] = {
> >> {USB_DEVICE(0x16d8, 0x8002)}, /* CMDTech Gobi 2000 Modem device (VU922) */
> >> {USB_DEVICE(0x05c6, 0x9204)}, /* Gobi 2000 QDL device */
> >> {USB_DEVICE(0x05c6, 0x9205)}, /* Gobi 2000 Modem device */
> >> + {USB_DEVICE(0x05c6, 0x901d)}, /* Foxconn SDX55 QDL */
> >
> >Why is this not sorted?
> >
> >And the subject needs some work still...
> >
> >thanks,
> >
> >greg k-h
>
> Hi Greg,
> Sorry, can you show me where should I put it at?
If it belongs in this list, then it should be in sorted order, which you
did not do here, so that would be a good idea, right?
> According to Bjørn comment, I think I need to create a new layout for Foxconn SDX55 device.
That is up to you and Bjørn to work out :)
thanks,
greg k-h
Powered by blists - more mailing lists