linux-kernel - Re:Re: [PATCH] [v2,1/1] This aims to support Foxconn SDX55

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <24551753.bf2.17b381cff23.Coremail.slark_xiao@163.com>
Date:   Thu, 12 Aug 2021 10:07:09 +0800 (CST)
From:   "Slark Xiao" <slark_xiao@....com>
To:     Bjørn Mork <bjorn@...k.no>
Cc:     johan@...nel.org, gregkh@...uxfoundation.org,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re:Re: [PATCH] [v2,1/1] This aims to support Foxconn SDX55

















At 2021-08-11 20:01:57, "Bjørn Mork" <bjorn@...k.no> wrote:
>Slark Xiao <slark_xiao@....com> writes:
>
>> diff --git a/drivers/usb/serial/qcserial.c b/drivers/usb/serial/qcserial.c
>> index 83da8236e3c8..d8b58aea3c60 100644
>> --- a/drivers/usb/serial/qcserial.c
>> +++ b/drivers/usb/serial/qcserial.c
>> @@ -111,6 +111,7 @@ static const struct usb_device_id id_table[] = {
>>  	{USB_DEVICE(0x16d8, 0x8002)},	/* CMDTech Gobi 2000 Modem device (VU922) */
>>  	{USB_DEVICE(0x05c6, 0x9204)},	/* Gobi 2000 QDL device */
>>  	{USB_DEVICE(0x05c6, 0x9205)},	/* Gobi 2000 Modem device */
>> +	{USB_DEVICE(0x05c6, 0x901d)},	/* Foxconn SDX55 QDL */
>
>I assume this device will expose other serial functions when booted in
>application USB mode?  But probably not with a Gobi 2k layout... Maybe
>add the application device ID to some USB serial driver too, and include
>the QDL device ID there as well to reduce confusion?
>
>Could you provide a view of the default USB descriptors in both QDL and
>application mode?  E.g from lsusb -v or  /sys/kernel/debug/usb/devices?
>
>
>Bjørn

Hi Bjørn,
  Thank you for your good advice. Actually it's my typo for 'QDL'. It should be 'Diag' port.
  Please see my local setting for PCIE+USB mode:

 jbd@...-ThinkPad-P1-Gen-4:~/git/net-next$ lsusb | grep 05c6
Bus 003 Device 003: ID 05c6:901d Qualcomm, Inc. Qualcomm HS-USB Android Diag 901D
jbd@...-ThinkPad-P1-Gen-4:~$ lspci | grep Foxconn
0000:08:00.0 Wireless controller [0d40]: Foxconn International, Inc. Device e0ab

  One more, should I add a new layout for Qualcomm SDX55 platform? As there are G1K,G2K, SIERRA and  HUAWEI layout, none of them includes Qualcomm SDX55.

Thanks