linux-kernel - Re: [PATCH v7 1/3] opp: Don't print an error if required-opps is missing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPDyKFoOta-4JX5ViJ6D5gArpQSobgecSV5yQ4SQ4-31_TMgcQ@mail.gmail.com>
Date:   Thu, 12 Aug 2021 13:45:46 +0200
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Rajendra Nayak <rnayak@...eaurora.org>
Cc:     Bjorn Andersson <bjorn.andersson@...aro.org>,
        Viresh Kumar <viresh.kumar@...aro.org>,
        Linux PM <linux-pm@...r.kernel.org>,
        DTML <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        Stephen Boyd <swboyd@...omium.org>,
        Roja Rani Yarubandi <rojay@...eaurora.org>,
        Stephan Gerhold <stephan@...hold.net>,
        Dmitry Osipenko <digetx@...il.com>
Subject: Re: [PATCH v7 1/3] opp: Don't print an error if required-opps is missing

On Thu, 12 Aug 2021 at 13:27, Rajendra Nayak <rnayak@...eaurora.org> wrote:
>
> The 'required-opps' property is considered optional, hence remove
> the pr_err() in of_parse_required_opp() when we find the property is
> missing.
> While at it, also fix the return value of
> of_get_required_opp_performance_state() when of_parse_required_opp()
> fails, return a -ENODEV instead of the -EINVAL.
>
> Signed-off-by: Rajendra Nayak <rnayak@...eaurora.org>

Reviewed-by: Ulf Hansson <ulf.hansson@...aro.org>

Kind regards
Uffe


> ---
>  drivers/opp/of.c | 12 ++----------
>  1 file changed, 2 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/opp/of.c b/drivers/opp/of.c
> index d298e38..9bdabad 100644
> --- a/drivers/opp/of.c
> +++ b/drivers/opp/of.c
> @@ -95,15 +95,7 @@ static struct dev_pm_opp *_find_opp_of_np(struct opp_table *opp_table,
>  static struct device_node *of_parse_required_opp(struct device_node *np,
>                                                  int index)
>  {
> -       struct device_node *required_np;
> -
> -       required_np = of_parse_phandle(np, "required-opps", index);
> -       if (unlikely(!required_np)) {
> -               pr_err("%s: Unable to parse required-opps: %pOF, index: %d\n",
> -                      __func__, np, index);
> -       }
> -
> -       return required_np;
> +       return of_parse_phandle(np, "required-opps", index);
>  }
>
>  /* The caller must call dev_pm_opp_put_opp_table() after the table is used */
> @@ -1327,7 +1319,7 @@ int of_get_required_opp_performance_state(struct device_node *np, int index)
>
>         required_np = of_parse_required_opp(np, index);
>         if (!required_np)
> -               return -EINVAL;
> +               return -ENODEV;
>
>         opp_table = _find_table_of_opp_np(required_np);
>         if (IS_ERR(opp_table)) {
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> of Code Aurora Forum, hosted by The Linux Foundation
>