linux-kernel - Re: [GIT PULL] tracing: Fixes and clean ups for v5.14

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cef5b624-b5f8-7729-3b05-3543578c6e3e@infradead.org>
Date:   Thu, 12 Aug 2021 11:04:38 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Linus Torvalds <torvalds@...ux-foundation.org>,
        Steven Rostedt <rostedt@...dmis.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Daniel Bristot de Oliveira <bristot@...nel.org>,
        Lukas Bulwahn <lukas.bulwahn@...il.com>,
        Masami Hiramatsu <mhiramat@...nel.org>
Subject: Re: [GIT PULL] tracing: Fixes and clean ups for v5.14

On 8/12/21 10:54 AM, Linus Torvalds wrote:
> On Thu, Aug 12, 2021 at 7:33 AM Steven Rostedt <rostedt@...dmis.org> wrote:
>>
>> That was my take too, when this was first addressed:
>>
>>    https://lore.kernel.org/lkml/20210730204050.46975ae2@oasis.local.home/
>>
>>>
>>> The commit message talks about "some compilers/analyzers" without any
>>> explanation, and the "Link:" thing doesn't link to anything useful
>>> either.

Yes, Steven wanted to use -Wno-main or whatever it is called from
the start.

>> I should have added the above link. :-/
> 
> Even the above link doesn't explain it to me.
> 
> What is it that gives this crazy garbage warning?
>
Some tool called gcc.

> It looks like Randy Dunlap compiles with the '-Wmain' flag, and then
> complains about it hurting.

I just used some default settings. I didn't choose to use -Wmain.

> It's a classic case of "Doctor, doctor, it hurts when I hit myself in
> the head with an ice pick".
> 
> The solution is not to take some Ibuprofen.
> 
> The solution is DON'T DO THAT THEN.
> 
> People who build with W=2 or some other crazy thing need to understand
> that the bad warnings it exposes are not kernel problems, they are
> THEIR problems.

Nah, it's a tooling problem.

-- 
~Randy