linux-kernel - Re: [GIT PULL] tracing: Fixes and clean ups for v5.14

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=wiEK+RooMgy+-vUbvfJi2PXCVh2K+ENeJszo6HyzYb-Cw@mail.gmail.com>
Date:   Thu, 12 Aug 2021 08:17:15 -1000
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     Steven Rostedt <rostedt@...dmis.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Daniel Bristot de Oliveira <bristot@...nel.org>,
        Lukas Bulwahn <lukas.bulwahn@...il.com>,
        Masami Hiramatsu <mhiramat@...nel.org>
Subject: Re: [GIT PULL] tracing: Fixes and clean ups for v5.14

On Thu, Aug 12, 2021 at 8:04 AM Randy Dunlap <rdunlap@...radead.org> wrote:
>
> I just used some default settings. I didn't choose to use -Wmain.

What broken distro, what broken gcc version?

We can certainly add a -Wno-main for this case. We already do that for
a lot of other idiotic warnings like -Wno-pointer-sign.

But when we do so, I want the exact tool and distro version named and
shamed. Because I sure don't see that warning, and from what I can
tell, most other people don't see it either.

So it's almost certainly your distro that has configured the gcc
install incorrectly - or some new gcc version that makes new insane
defaults. The commit message should talk about those kinds of details,
exactly so that people like me get an explanation for why we'd need
that odd '-Wno-main' flag.

Maybe even the line in the Makefile should have it. Like that
-Wno-pointer-sign thing does:

  # disable pointer signed / unsigned warnings in gcc 4.0
  KBUILD_CFLAGS += -Wno-pointer-sign

just because unexplained random compiler flags are a bad thing (the
same way unexplained random code changes due to them are bad)

                Linus