| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAL_JsqLg-jD1P3oGDocMaeHWQc+9kLr3gEdantRNUScUq5xsQw@mail.gmail.com>
Date: Wed, 11 Aug 2021 22:13:32 -0500
From: Rob Herring <robh@...nel.org>
To: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
Cc: Linuxarm <linuxarm@...wei.com>, mauro.chehab@...wei.com,
Binghui Wang <wangbinghui@...ilicon.com>,
Gustavo Pimentel <gustavo.pimentel@...opsys.com>,
Jingoo Han <jingoohan1@...il.com>,
Xiaowei Song <songxiaowei@...ilicon.com>,
devicetree@...r.kernel.org,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
PCI <linux-pci@...r.kernel.org>, linux-phy@...ts.infradead.org
Subject: Re: [PATCH v3 0/4] DT schema changes for HiKey970 PCIe hardware to work
On Wed, Aug 11, 2021 at 1:46 AM Mauro Carvalho Chehab
<mchehab+huawei@...nel.org> wrote:
>
> Em Tue, 10 Aug 2021 11:13:48 -0600
> Rob Herring <robh@...nel.org> escreveu:
>
> > > > > compatible = "pciclass,0604";
> > > > > device_type = "pci";
> > > > > #address-cells = <3>;
> > > > > #size-cells = <2>;
> > > > > ranges;
> > > > > };
> > > > > pcie@1,0 { // Lane 4: M.2
> > > >
> > > > These 3 nodes (1, 5, 7) need to be child nodes of the above node.
> >
> > This was the main issue.
>
> Ok, placing 1, 5, 7 as child nodes of 0 worked, with the attached
> DT schema:
>
>
> $ ls -l $(find /sys/devices/platform/soc/f4000000.pcie/ -name of_node)
> lrwxrwxrwx 1 root root 0 ago 11 08:43 /sys/devices/platform/soc/f4000000.pcie/of_node -> ../../../../firmware/devicetree/base/soc/pcie@...00000
> lrwxrwxrwx 1 root root 0 ago 11 08:43 /sys/devices/platform/soc/f4000000.pcie/pci0000:00/0000:00:00.0/0000:01:00.0/0000:02:01.0/of_node -> ../../../../../../../../firmware/devicetree/base/soc/pcie@...00000/pcie@0,0/pcie@0,0/pcie@1,0
> lrwxrwxrwx 1 root root 0 ago 11 08:43 /sys/devices/platform/soc/f4000000.pcie/pci0000:00/0000:00:00.0/0000:01:00.0/0000:02:01.0/pci_bus/0000:03/of_node -> ../../../../../../../../../../firmware/devicetree/base/soc/pcie@...00000/pcie@0,0/pcie@0,0/pcie@1,0
> lrwxrwxrwx 1 root root 0 ago 11 08:43 /sys/devices/platform/soc/f4000000.pcie/pci0000:00/0000:00:00.0/0000:01:00.0/0000:02:05.0/of_node -> ../../../../../../../../firmware/devicetree/base/soc/pcie@...00000/pcie@0,0/pcie@0,0/pcie@5,0
> lrwxrwxrwx 1 root root 0 ago 11 08:43 /sys/devices/platform/soc/f4000000.pcie/pci0000:00/0000:00:00.0/0000:01:00.0/0000:02:05.0/pci_bus/0000:05/of_node -> ../../../../../../../../../../firmware/devicetree/base/soc/pcie@...00000/pcie@0,0/pcie@0,0/pcie@5,0
> lrwxrwxrwx 1 root root 0 ago 11 08:43 /sys/devices/platform/soc/f4000000.pcie/pci0000:00/0000:00:00.0/0000:01:00.0/0000:02:07.0/of_node -> ../../../../../../../../firmware/devicetree/base/soc/pcie@...00000/pcie@0,0/pcie@0,0/pcie@7,0
> lrwxrwxrwx 1 root root 0 ago 11 08:43 /sys/devices/platform/soc/f4000000.pcie/pci0000:00/0000:00:00.0/0000:01:00.0/0000:02:07.0/pci_bus/0000:06/of_node -> ../../../../../../../../../../firmware/devicetree/base/soc/pcie@...00000/pcie@0,0/pcie@0,0/pcie@7,0
> lrwxrwxrwx 1 root root 0 ago 11 08:43 /sys/devices/platform/soc/f4000000.pcie/pci0000:00/0000:00:00.0/0000:01:00.0/of_node -> ../../../../../../../firmware/devicetree/base/soc/pcie@...00000/pcie@0,0/pcie@0,0
> lrwxrwxrwx 1 root root 0 ago 11 08:43 /sys/devices/platform/soc/f4000000.pcie/pci0000:00/0000:00:00.0/0000:01:00.0/pci_bus/0000:02/of_node -> ../../../../../../../../../firmware/devicetree/base/soc/pcie@...00000/pcie@0,0/pcie@0,0
> lrwxrwxrwx 1 root root 0 ago 11 08:43 /sys/devices/platform/soc/f4000000.pcie/pci0000:00/0000:00:00.0/of_node -> ../../../../../../firmware/devicetree/base/soc/pcie@...00000/pcie@0,0
> lrwxrwxrwx 1 root root 0 ago 11 08:43 /sys/devices/platform/soc/f4000000.pcie/pci0000:00/0000:00:00.0/pci_bus/0000:01/of_node -> ../../../../../../../../firmware/devicetree/base/soc/pcie@...00000/pcie@0,0
> lrwxrwxrwx 1 root root 0 ago 11 08:43 /sys/devices/platform/soc/f4000000.pcie/pci0000:00/pci_bus/0000:00/of_node -> ../../../../../../../firmware/devicetree/base/soc/pcie@...00000
This all looks right to me, but...
> The logs also seem OK on my eyes:
>
> [ 3.911082] (null): pci_set_bus_of_node: of_node: /soc/pcie@...00000
> [ 4.001104] pci 0000:00:00.0: pci_set_of_node: of_node: /soc/pcie@...00000
> [ 4.043609] pci_bus 0000:01: pci_set_bus_of_node: of_node: /soc/pcie@...00000/pcie@0,0
> [ 4.076756] pci 0000:01:00.0: pci_set_of_node: of_node: /soc/pcie@...00000/pcie@0,0
> [ 4.120652] pci_bus 0000:02: pci_set_bus_of_node: of_node: /soc/pcie@...00000/pcie@0,0/pcie@0,0
> [ 4.150766] pci 0000:02:01.0: pci_set_of_node: of_node: /soc/pcie@...00000/pcie@0,0/pcie@0,0
> [ 4.196413] pci 0000:02:04.0: pci_set_of_node: of_node: /soc/pcie@...00000/pcie@0,0/pcie@0,0
> [ 4.238896] pci 0000:02:05.0: pci_set_of_node: of_node: /soc/pcie@...00000/pcie@0,0/pcie@0,0
> [ 4.280116] pci 0000:02:07.0: pci_set_of_node: of_node: /soc/pcie@...00000/pcie@0,0/pcie@0,0
> [ 4.309821] pci 0000:02:09.0: pci_set_of_node: of_node: /soc/pcie@...00000/pcie@0,0/pcie@0,0
...these do not.
> [ 4.370830] pci_bus 0000:03: pci_set_bus_of_node: of_node: /soc/pcie@...00000/pcie@0,0/pcie@0,0/pcie@1,0
> [ 4.382345] pci_bus 0000:04: pci_set_bus_of_node: of_node: (null)
> [ 4.411966] pci_bus 0000:05: pci_set_bus_of_node: of_node: /soc/pcie@...00000/pcie@0,0/pcie@0,0/pcie@5,0
> [ 4.439898] pci_bus 0000:06: pci_set_bus_of_node: of_node: /soc/pcie@...00000/pcie@0,0/pcie@0,0/pcie@7,0
> [ 4.491616] pci 0000:06:00.0: pci_set_of_node: of_node: /soc/pcie@...00000/pcie@0,0/pcie@0,0/pcie@7,0
> [ 4.519907] pci_bus 0000:07: pci_set_bus_of_node: of_node: (null)
Powered by blists - more mailing lists