lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20210812131921.a1c5c85213290e1729cc72a3@linux-foundation.org> Date: Thu, 12 Aug 2021 13:19:21 -0700 From: Andrew Morton <akpm@...ux-foundation.org> To: SeongJae Park <sj38.park@...il.com> Cc: =?UTF-8?Q? "Valdis_Kl=C4=93tnieks" ?= <valdis.kletnieks@...edu>, SeongJae Park <sjpark@...zon.de>, linux-mm@...ck.org, linux-kernel@...r.kernel.org Subject: Re: On Thu, 12 Aug 2021 09:42:40 +0000 SeongJae Park <sj38.park@...il.com> wrote: > > +config PAGE_IDLE_FLAG > > + bool "Add PG_idle and PG_young flags" > > + help > > + This feature adds PG_idle and PG_young flags in 'struct page'. PTE > > + Accessed bit writers can set the state of the bit in the flags to let > > + other PTE Accessed bit readers don't disturbed. > > > > This needs to be converted to proper, or at least comprehensible, English.... > > Thank you for the comment. > > How about below? > > --- a/mm/Kconfig > +++ b/mm/Kconfig > @@ -743,9 +743,9 @@ config PAGE_IDLE_FLAG > bool "Add PG_idle and PG_young flags" > select PAGE_EXTENSION if !64BIT > help > - This feature adds PG_idle and PG_young flags in 'struct page'. PTE > - Accessed bit writers can set the state of the bit in the flags to let > - other PTE Accessed bit readers don't disturbed. > + This feature adds 'PG_idle' and 'PG_young' flags in 'struct page'. > + PTE Accessed bit writers can save the state of the bit in the flags > + to let other PTE Accessed bit readers don't get disturbed. How about this? --- a/mm/Kconfig~mm-idle_page_tracking-make-pg_idle-reusable-fix-fix +++ a/mm/Kconfig @@ -743,9 +743,9 @@ config PAGE_IDLE_FLAG bool "Add PG_idle and PG_young flags" select PAGE_EXTENSION if !64BIT help - This feature adds PG_idle and PG_young flags in 'struct page'. PTE - Accessed bit writers can set the state of the bit in the flags to let - other PTE Accessed bit readers don't disturbed. + This adds PG_idle and PG_young flags to 'struct page'. PTE Accessed + bit writers can set the state of the bit in the flags so that PTE + Accessed bit readers may avoid disturbance. config IDLE_PAGE_TRACKING bool "Enable idle page tracking" Also, is there any way in which we can avoid presenting this option to the user? Because most users will have real trouble understanding what this thing is for. Can we simply select it when needed, as dictated by other, higher-level config options?
Powered by blists - more mailing lists