linux-kernel - Re: [PATCH v14 062/138] mm/migrate: Add folio_migrate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c33999ee-64ce-cf00-a457-66fb6b90a64d@suse.cz>
Date:   Fri, 13 Aug 2021 10:33:19 +0200
From:   Vlastimil Babka <vbabka@...e.cz>
To:     Matthew Wilcox <willy@...radead.org>
Cc:     linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH v14 062/138] mm/migrate: Add folio_migrate_copy()

On 8/13/21 6:16 AM, Matthew Wilcox wrote:
> On Thu, Aug 12, 2021 at 01:56:24PM +0200, Vlastimil Babka wrote:
>> On 7/15/21 5:35 AM, Matthew Wilcox (Oracle) wrote:
>> > This is the folio equivalent of migrate_page_copy(), which is retained
>> > as a wrapper for filesystems which are not yet converted to folios.
>> > Also convert copy_huge_page() to folio_copy().
>> > 
>> > Signed-off-by: Matthew Wilcox (Oracle) <willy@...radead.org>
>> 
>> Acked-by: Vlastimil Babka <vbabka@...e.cz>
>> 
>> The way folio_copy() avoids cond_resched() for single page would IMHO deserve a
>> comment though, so it's not buried only in this thread.
> 
> I think folio_copy() deserves kernel-doc.
> 
> /**
>  * folio_copy - Copy the contents of one folio to another.
>  * @dst: Folio to copy to.
>  * @src: Folio to copy from.
>  *
>  * The bytes in the folio represented by @src are copied to @dst.
>  * Assumes the caller has validated that @dst is at least as large as @src.
>  * Can be called in atomic context for order-0 folios, but if the folio is
>  * larger, it may sleep.
>  */
> 
LGTM.