linux-kernel - Re: [PATCH] f2fs: convert /sys/fs/f2fs/<disk>/stat/sb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9b000232-c3dc-458c-2507-1dde8a8d985c@kernel.org>
Date:   Fri, 13 Aug 2021 22:41:02 +0800
From:   Chao Yu <chao@...nel.org>
To:     李扬韬 <frank.li@...o.com>
Cc:     jaegeuk@...nel.org, linux-f2fs-devel@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] f2fs: convert /sys/fs/f2fs/<disk>/stat/sb_status to use
 string

On 2021/8/13 22:17, 李扬韬 wrote:
> HI Chao,
> 
> From: Chao Yu <chao@...nel.org>
> Date: 2021-08-13 22:09:53
> To:  Yangtao Li <frank.li@...o.com>,jaegeuk@...nel.org
> Cc:  linux-f2fs-devel@...ts.sourceforge.net,linux-kernel@...r.kernel.org
> Subject: Re: [PATCH] f2fs: convert /sys/fs/f2fs/<disk>/stat/sb_status to use string>On 2021/8/13 22:01, Yangtao Li wrote:
>>> Do not use numbers but strings to improve readability when flag is set.
>>
>> This breaks output rule of sysfs entry, see below link:
>>
> Which rule? one entry should show one value？

Yes, one value per file please, which is suggested by Greg.

https://lkml.org/lkml/2021/6/3/319

> 
> But I see that:
> # cat /sys/fs/f2fs/<disk>/features
> encryption, quota_ino, verity, pin_file
> 
> So the format of features also wrong?

  What:		/sys/fs/f2fs/<disk>/features
  Date:		July 2017
  Contact:	"Jaegeuk Kim" <jaegeuk@...nel.org>
  Description:	<deprecated: should use /sys/fs/f2fs/<disk>/feature_list/

Thanks,

> 
> Thx，
>