linux-kernel - Re:Re: [PATCH] f2fs: convert /sys/fs/f2fs/<disk>/stat/sb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AHAA5gBVD-NcU6Btsog*u4qC.3.1628866526180.Hmail.frank.li@vivo.com>
Date:   Fri, 13 Aug 2021 22:55:26 +0800 (GMT+08:00)
From:   李扬韬 <frank.li@...o.com>
To:     Chao Yu <chao@...nel.org>
Cc:     jaegeuk@...nel.org, linux-f2fs-devel@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org
Subject: Re:Re: [PATCH] f2fs: convert /sys/fs/f2fs/<disk>/stat/sb_status to use string

发件人：Chao Yu <chao@...nel.org>
发送日期：2021-08-13 22:41:02
收件人："李扬韬" <frank.li@...o.com>
抄送人：jaegeuk@...nel.org,linux-f2fs-devel@...ts.sourceforge.net,linux-kernel@...r.kernel.org
主题：Re: [PATCH] f2fs: convert /sys/fs/f2fs/<disk>/stat/sb_status to use string>On 2021/8/13 22:17, 李扬韬 wrote:
>> HI Chao,
>> 
>> From: Chao Yu <chao@...nel.org>
>> Date: 2021-08-13 22:09:53
>> To:  Yangtao Li <frank.li@...o.com>,jaegeuk@...nel.org
>> Cc:  linux-f2fs-devel@...ts.sourceforge.net,linux-kernel@...r.kernel.org
>> Subject: Re: [PATCH] f2fs: convert /sys/fs/f2fs/<disk>/stat/sb_status to use string>On 2021/8/13 22:01, Yangtao Li wrote:
>>>> Do not use numbers but strings to improve readability when flag is set.
>>>
>>> This breaks output rule of sysfs entry, see below link:
>>>
>> Which rule? one entry should show one value？
>
>Yes, one value per file please, which is suggested by Greg.
>
>https://lkml.org/lkml/2021/6/3/319
>
>> 
>> But I see that:
>> # cat /sys/fs/f2fs/<disk>/features
>> encryption, quota_ino, verity, pin_file
>> 
>> So the format of features also wrong?
>
>  What:		/sys/fs/f2fs/<disk>/features
>  Date:		July 2017
>  Contact:	"Jaegeuk Kim" <jaegeuk@...nel.org>
>  Description:	<deprecated: should use /sys/fs/f2fs/<disk>/feature_list/

OK, So Maybe we can make something like following？

/sys/fs/f2fs/<disk>/sbi_status/fsck 

Yangtao