linux-kernel - Re: [PATCH -next 1/2] selftests: Fix vm_handle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f130f6ec-0c80-7a83-fad2-7d72d389b96b@linuxfoundation.org>
Date:   Fri, 13 Aug 2021 11:01:16 -0600
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     Chen Lifu <chenlifu@...wei.com>, pbonzini@...hat.com,
        shuah@...nel.org, bgardon@...gle.com, wangyanan55@...wei.com,
        axelrasmussen@...gle.com, drjones@...hat.com, seanjc@...gle.com,
        vkuznets@...hat.com, dwmw@...zon.co.uk, joao.m.martins@...cle.com,
        yangyingliang@...wei.com, kvm@...r.kernel.org,
        linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH -next 1/2] selftests: Fix vm_handle_exception undefined
 error

On 7/9/21 12:37 AM, Chen Lifu wrote:
> Compile setftests on x86_64 occurs following error:
> make -C tools/testing/selftests
> ...
> 
> x86_64/hyperv_features.c:618:2: warning: implicit declaration of function ‘vm_handle_exception’ [-Wimplicit-function-declaration]
>    618 |  vm_handle_exception(vm, GP_VECTOR, guest_gp_handler);
> /usr/bin/ld: /tmp/cclOnpml.o: in function `main':
> tools/testing/selftests/kvm/x86_64/hyperv_features.c:618: undefined reference to `vm_handle_exception'
> collect2: error: ld returned 1 exit status
> 
> The reason is that commit b78f4a596692 ("KVM: selftests: Rename vm_handle_exception")
> renamed "vm_handle_exception" function to "vm_install_exception_handler" function.
> 
> Fix it by replacing "vm_handle_exception" with "vm_install_exception_handler"
> in corresponding selftests files.
> 
> Signed-off-by: Chen Lifu <chenlifu@...wei.com>
> ---
>   tools/testing/selftests/kvm/x86_64/hyperv_features.c | 2 +-
>   tools/testing/selftests/kvm/x86_64/mmu_role_test.c   | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 


Please include kvm in the commit summary. I think it is not getting
the right attention because of the summary line.

Same for the second patch in this series.

thanks,
-- Shuah