linux-kernel - Re: [PATCH 1/2] pinctrl: qcom: spmi-gpio: correct parent irqspec translation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4af8171aefd6f0387438225666ec1ccc@codeaurora.org>
Date:   Mon, 16 Aug 2021 12:20:37 +0530
From:   skakit@...eaurora.org
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     Rob Herring <robh+dt@...nel.org>, Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        David Collins <collinsd@...eaurora.org>,
        Kiran Gunda <kgunda@...eaurora.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>, MSM <linux-arm-msm@...r.kernel.org>
Subject: Re: [PATCH 1/2] pinctrl: qcom: spmi-gpio: correct parent irqspec
 translation

Hi Linus,

On 2021-08-13 14:27, Linus Walleij wrote:
> Hi Satya/David,
> 
> nice work on identifying this bug!
> 
> On Fri, Aug 13, 2021 at 6:56 AM satya priya <skakit@...eaurora.org> 
> wrote:
>> 
>> From: David Collins <collinsd@...eaurora.org>
>> 
>> pmic_gpio_child_to_parent_hwirq() and
>> gpiochip_populate_parent_fwspec_fourcell() translate a pinctrl-
>> spmi-gpio irqspec to an SPMI controller irqspec.  When they do
>> this, they use a fixed SPMI slave ID of 0 and a fixed GPIO
>> peripheral offset of 0xC0 (corresponding to SPMI address 0xC000).
>> This translation results in an incorrect irqspec for secondary
>> PMICs that don't have a slave ID of 0 as well as for PMIC chips
>> which have GPIO peripherals located at a base address other than
>> 0xC000.
>> 
>> Correct this issue by passing the slave ID of the pinctrl-spmi-
>> gpio device's parent in the SPMI controller irqspec and by
>> calculating the peripheral ID base from the device tree 'reg'
>> property of the pinctrl-spmi-gpio device.
>> 
>> Signed-off-by: David Collins <collinsd@...eaurora.org>
>> Signed-off-by: satya priya <skakit@...eaurora.org>
> 
> Is this a regression or is it fine if I just apply it for v5.15?
> I was thinking v5.15 since it isn't yet used in device trees.
> 

Without this fix, [2/2] Vol+ support is failing. If possible please 
merge it on current branch.

> Yours,
> Linus Walleij