linux-kernel - [PATCH] char: misc: init list head only when needed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <853e8529c18c4a71c36b49f9598961fbc3f39682.1628921932.git.lijiazi@xiaomi.com>
Date:   Mon, 16 Aug 2021 18:12:32 +0800
From:   Jiazi Li <jqqlijiazi@...il.com>
To:     Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Jiazi Li <lijiazi@...omi.com>, linux-kernel@...r.kernel.org
Subject: [PATCH] char: misc: init list head only when needed

If a module successfully registers a misc device.
Then, due to some bugs, use same address register misc device
again, init list head will corrupt misc_list, resulting in oops
when using misc_list.

In this scenario, do not init list head, if registration is
successful, init list head is also not required.

Signed-off-by: Jiazi Li <lijiazi@...omi.com>
---
 drivers/char/misc.c | 19 ++++++++++++++-----
 1 file changed, 14 insertions(+), 5 deletions(-)

diff --git a/drivers/char/misc.c b/drivers/char/misc.c
index ca5141e..2451640 100644
--- a/drivers/char/misc.c
+++ b/drivers/char/misc.c
@@ -176,7 +176,6 @@ int misc_register(struct miscdevice *misc)
 	int err = 0;
 	bool is_dynamic = (misc->minor == MISC_DYNAMIC_MINOR);
 
-	INIT_LIST_HEAD(&misc->list);
 
 	mutex_lock(&misc_mtx);
 
@@ -185,7 +184,7 @@ int misc_register(struct miscdevice *misc)
 
 		if (i >= DYNAMIC_MINORS) {
 			err = -EBUSY;
-			goto out;
+			goto err2;
 		}
 		misc->minor = DYNAMIC_MINORS - i - 1;
 		set_bit(i, misc_minors);
@@ -195,7 +194,13 @@ int misc_register(struct miscdevice *misc)
 		list_for_each_entry(c, &misc_list, list) {
 			if (c->minor == misc->minor) {
 				err = -EBUSY;
-				goto out;
+				/*
+				 * if module use same address double register,
+				 * init list will corrupt misc_list
+				 */
+				if (c == misc)
+					goto err1;
+				goto err2;
 			}
 		}
 	}
@@ -214,7 +219,7 @@ int misc_register(struct miscdevice *misc)
 			misc->minor = MISC_DYNAMIC_MINOR;
 		}
 		err = PTR_ERR(misc->this_device);
-		goto out;
+		goto err2;
 	}
 
 	/*
@@ -222,7 +227,11 @@ int misc_register(struct miscdevice *misc)
 	 * earlier defaults
 	 */
 	list_add(&misc->list, &misc_list);
- out:
+	mutex_unlock(&misc_mtx);
+	return 0;
+ err2:
+	INIT_LIST_HEAD(&misc->list);
+ err1:
 	mutex_unlock(&misc_mtx);
 	return err;
 }
-- 
2.7.4