linux-kernel - Re: [RFC v2 net-next 3/8] net: mscc: ocelot: set vcap IS2 chain to goto PSFP chain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210818145435.bsbxuq7bbjr4fkel@skbuf>
Date:   Wed, 18 Aug 2021 14:54:35 +0000
From:   Vladimir Oltean <vladimir.oltean@....com>
To:     Xiaoliang Yang <xiaoliang.yang_1@....com>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "allan.nielsen@...rochip.com" <allan.nielsen@...rochip.com>,
        "joergen.andreasen@...rochip.com" <joergen.andreasen@...rochip.com>,
        "UNGLinuxDriver@...rochip.com" <UNGLinuxDriver@...rochip.com>,
        "vinicius.gomes@...el.com" <vinicius.gomes@...el.com>,
        "michael.chan@...adcom.com" <michael.chan@...adcom.com>,
        "vishal@...lsio.com" <vishal@...lsio.com>,
        "saeedm@...lanox.com" <saeedm@...lanox.com>,
        "jiri@...lanox.com" <jiri@...lanox.com>,
        "idosch@...lanox.com" <idosch@...lanox.com>,
        "alexandre.belloni@...tlin.com" <alexandre.belloni@...tlin.com>,
        "kuba@...nel.org" <kuba@...nel.org>, Po Liu <po.liu@....com>,
        Leo Li <leoyang.li@....com>
Subject: Re: [RFC v2 net-next 3/8] net: mscc: ocelot: set vcap IS2 chain to
 goto PSFP chain

On Wed, Aug 18, 2021 at 02:19:17PM +0800, Xiaoliang Yang wrote:
> @@ -353,7 +364,7 @@ static int ocelot_flower_parse_action(struct ocelot *ocelot, int port,
>  
>  	if (filter->goto_target == -1) {
>  		if ((filter->block_id == VCAP_IS2 && filter->lookup == 1) ||
> -		    chain == 0) {
> +		    chain == 0 || filter->block_id == PSFP_BLOCK_ID) {
>  			allow_missing_goto_target = true;

I would like to not allow missing "goto" targets for new filter chains.

Due to legacy support we must keep support for VCAP IS2 on chain 0, but
ever since we added the ability to offload multiple chains corresponding
to multiple hardware blocks, we should really use that precise chain ID,
and chain 0 should just goto the first used chain in the pipeline.

Makes sense?

>  		} else {
>  			NL_SET_ERR_MSG_MOD(extack, "Missing GOTO action");
> -- 
> 2.17.1
>