linux-kernel - Re: [RFC v2 net-next 4/8] net: mscc: ocelot: add gate and police action offload to PSFP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210818150053.numtnvntscxcm6r4@skbuf>
Date:   Wed, 18 Aug 2021 15:00:54 +0000
From:   Vladimir Oltean <vladimir.oltean@....com>
To:     Xiaoliang Yang <xiaoliang.yang_1@....com>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "allan.nielsen@...rochip.com" <allan.nielsen@...rochip.com>,
        "joergen.andreasen@...rochip.com" <joergen.andreasen@...rochip.com>,
        "UNGLinuxDriver@...rochip.com" <UNGLinuxDriver@...rochip.com>,
        "vinicius.gomes@...el.com" <vinicius.gomes@...el.com>,
        "michael.chan@...adcom.com" <michael.chan@...adcom.com>,
        "vishal@...lsio.com" <vishal@...lsio.com>,
        "saeedm@...lanox.com" <saeedm@...lanox.com>,
        "jiri@...lanox.com" <jiri@...lanox.com>,
        "idosch@...lanox.com" <idosch@...lanox.com>,
        "alexandre.belloni@...tlin.com" <alexandre.belloni@...tlin.com>,
        "kuba@...nel.org" <kuba@...nel.org>, Po Liu <po.liu@....com>,
        Leo Li <leoyang.li@....com>
Subject: Re: [RFC v2 net-next 4/8] net: mscc: ocelot: add gate and police
 action offload to PSFP

On Wed, Aug 18, 2021 at 02:19:18PM +0800, Xiaoliang Yang wrote:
> @@ -718,6 +734,15 @@ int ocelot_cls_flower_replace(struct ocelot *ocelot, int port,
>  	if (filter->type == OCELOT_VCAP_FILTER_DUMMY)
>  		return ocelot_vcap_dummy_filter_add(ocelot, filter);
>  
> +	if (filter->type == OCELOT_PSFP_FILTER_OFFLOAD) {
> +		kfree(filter);
> +		if (ocelot->ops->psfp_filter_add)
> +			return ocelot->ops->psfp_filter_add(ocelot, f);
> +
> +		NL_SET_ERR_MSG_MOD(extack, "PSFP chain is not supported in HW");
> +		return -EOPNOTSUPP;
> +	}
> +
>  	return ocelot_vcap_filter_add(ocelot, filter, f->common.extack);
>  }

Hmm, I don't really like the idea of allocating an ocelot_vcap_filter
which we don't need for PSFP filters, just to kfree it later.

Is it that much more complicated to not allocate it at all in the first
place, add a bunch of "if" conditions that allocate a VCAP filter only
if we are offloading a VCAP chain?

And that means, don't create ocelot_vcap_filter::type == OCELOT_PSFP_FILTER_OFFLOAD,
because PSFP filters are not VCAP filters.