| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <b152a497-9cbe-83fa-e04a-f5d2a5b875f3@redhat.com>
Date: Thu, 19 Aug 2021 20:46:14 +0200
From: Hans de Goede <hdegoede@...hat.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
Kate Hsuan <hpa@...hat.com>,
Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
linux-kernel@...r.kernel.org, platform-driver-x86@...r.kernel.org,
Dell.Client.Kernel@...l.com
Cc: Mark Gross <mgross@...ux.intel.com>,
Alex Hung <alex.hung@...onical.com>,
Rajneesh Bhardwaj <irenic.rajneesh@...il.com>,
David E Box <david.e.box@...el.com>,
Zha Qipeng <qipeng.zha@...el.com>,
Mika Westerberg <mika.westerberg@...ux.intel.com>,
"David E. Box" <david.e.box@...ux.intel.com>,
AceLan Kao <acelan.kao@...onical.com>,
Jithu Joseph <jithu.joseph@...el.com>,
Maurice Ma <maurice.ma@...el.com>
Subject: Re: [PATCH v4 00/21] platform/x86: Intel platform driver code
movement
Hi,
On 8/19/21 6:37 PM, Andy Shevchenko wrote:
> This is v4 of the Intel drivers move on in the source tree.
> v3 has been done by Kate:
> https://lore.kernel.org/platform-driver-x86/20210819033001.20136-1-hpa@redhat.com/
>
> I have taken the initial set from review-hans branch and removed Hans' SoB
> along with Link, while leaving others' tags.
>
> Changelog v4:
> - spelled fully the driver names in the commit messages
> - fixed SCU *.ko module names
Actually I checked this during review and
CONFIG_INTEL_SCU_IPC, CONFIG_INTEL_SCU_PCI and CONFIG_INTEL_SCU_WDT
are booleans, iow if enabled they are always builtin so the
drivers/platform/x86/intel/scu/Makefile from v3 was correct.
Since the v3 Makefile is more simple I prefer that version,
but if you prefer to keep the v4 version that is fine too.
> - dropped extra prefix in PMC files
> - dropped stray changes within the series
> - removed confusing comments in Makefile and Kconfig files
> - embedded a few of Kconfig improvements here and there (ordering, spelling)
> - split miscellaneous group
> - added a patch to fix kernel doc issue in SCU IPC code
Thanks, I've not (re)reviewed things, but this all sounds good.
> So, I have noticed the report about SCU and taking into account IPS
> header deferred move, I think those two should be excluded from the
> series and sent after rc1, it will also eliminate trampoline move for
> IPS header, since we may send one patch which includes DRM changes.
>
> Hans, what do you think?
Fixing the SCU thing will require coordination with / an
ack from the MFD maintainer (Lee) so yeah dropping that for
now and doing the SCU move next cycle is probably the best.
Dropping the IPS move for now is fine with me too.
Can you send a v5 with those 2 patches dropped ?
We can still fix the SCU doc, just in the old place...
Regards,
Hans
>
> Andy Shevchenko (1):
> platform/x86/intel: scu: Fix doc of
> intel_scu_ipc_dev_command_with_size()
>
> Kate Hsuan (20):
> platform/x86: intel_bxtwc_tmu: Move to intel sub-directory
> platform/x86: intel_chtdc_ti_pwrbtn: Move to intel sub-directory
> platform/x86: intel_mrfld_pwrbtn: Move to intel sub-directory
> platform/x86: intel_punit_ipc: Move to intel sub-directory
> platform/x86: intel_pmc_core: Move to intel sub-directory
> platform/x86: intel_scu: Move to intel sub-directory
> platform/x86: intel_telemetry: Move to intel sub-directory
> platform/x86: intel_ips: Move to intel sub-directory
> platform/x86: intel-rst: Move to intel sub-directory
> platform/x86: intel-smartconnect: Move to intel sub-directory
> platform/x86: intel_turbo_max_3: Move to intel sub-directory
> platform/x86: intel-uncore-frequency: Move to intel sub-directory
> platform/x86: intel_speed_select_if: Move to intel sub-directory
> platform/x86: intel_atomisp2: Move to intel sub-directory
> platform/x86: intel-hid: Move to intel sub-directory
> platform/x86: intel_int0002_vgpio: Move to intel sub-directory
> platform/x86: intel_oaktrail: Move to intel sub-directory
> platform/x86: intel-vbtn: Move to intel sub-directory
> platform/x86: intel-wmi-sbl-fw-update: Move to intel sub-directory
> platform/x86: intel-wmi-thunderbolt: Move to intel sub-directory
>
> MAINTAINERS | 24 +-
> drivers/platform/x86/Kconfig | 288 ------------------
> drivers/platform/x86/Makefile | 31 --
> drivers/platform/x86/intel/Kconfig | 158 ++++++++++
> drivers/platform/x86/intel/Makefile | 40 +++
> drivers/platform/x86/intel/atomisp2/Kconfig | 43 +++
> drivers/platform/x86/intel/atomisp2/Makefile | 9 +
> .../atomisp2/led.c} | 0
> .../atomisp2/pm.c} | 0
> .../{intel_bxtwc_tmu.c => intel/bxtwc_tmu.c} | 0
> .../chtdc_ti_pwrbtn.c} | 0
> .../platform/x86/{intel-hid.c => intel/hid.c} | 2 +-
> .../int0002_vgpio.c} | 0
> .../platform/x86/{intel_ips.c => intel/ips.c} | 3 +-
> .../mrfld_pwrbtn.c} | 0
> .../{intel_oaktrail.c => intel/oaktrail.c} | 0
> drivers/platform/x86/intel/pmc/Kconfig | 25 ++
> drivers/platform/x86/intel/pmc/Makefile | 9 +
> .../{intel_pmc_core.c => intel/pmc/core.c} | 2 +-
> .../{intel_pmc_core.h => intel/pmc/core.h} | 0
> .../pmc/pltdrv.c} | 0
> .../{intel_punit_ipc.c => intel/punit_ipc.c} | 0
> .../platform/x86/{intel-rst.c => intel/rst.c} | 0
> drivers/platform/x86/intel/scu/Kconfig | 51 ++++
> drivers/platform/x86/intel/scu/Makefile | 15 +
> .../x86/{intel_scu_ipc.c => intel/scu/ipc.c} | 2 +-
> .../scu/ipcutil.c} | 0
> .../scu/pcidrv.c} | 0
> .../scu/pltdrv.c} | 0
> .../x86/{intel_scu_wdt.c => intel/scu/wdt.c} | 0
> .../smartconnect.c} | 0
> .../speed_select_if}/Kconfig | 0
> .../speed_select_if}/Makefile | 0
> .../speed_select_if}/isst_if_common.c | 0
> .../speed_select_if}/isst_if_common.h | 0
> .../speed_select_if}/isst_if_mbox_msr.c | 0
> .../speed_select_if}/isst_if_mbox_pci.c | 0
> .../speed_select_if}/isst_if_mmio.c | 0
> drivers/platform/x86/intel/telemetry/Kconfig | 16 +
> drivers/platform/x86/intel/telemetry/Makefile | 11 +
> .../telemetry/core.c} | 0
> .../telemetry/debugfs.c} | 0
> .../telemetry/pltdrv.c} | 0
> .../turbo_max_3.c} | 0
> .../uncore-frequency.c} | 0
> .../x86/{intel-vbtn.c => intel/vbtn.c} | 2 +-
> drivers/platform/x86/intel/wmi/Kconfig | 31 ++
> drivers/platform/x86/intel/wmi/Makefile | 9 +
> .../wmi/sbl-fw-update.c} | 0
> .../wmi/thunderbolt.c} | 0
> 50 files changed, 435 insertions(+), 336 deletions(-)
> create mode 100644 drivers/platform/x86/intel/atomisp2/Kconfig
> create mode 100644 drivers/platform/x86/intel/atomisp2/Makefile
> rename drivers/platform/x86/{intel_atomisp2_led.c => intel/atomisp2/led.c} (100%)
> rename drivers/platform/x86/{intel_atomisp2_pm.c => intel/atomisp2/pm.c} (100%)
> rename drivers/platform/x86/{intel_bxtwc_tmu.c => intel/bxtwc_tmu.c} (100%)
> rename drivers/platform/x86/{intel_chtdc_ti_pwrbtn.c => intel/chtdc_ti_pwrbtn.c} (100%)
> rename drivers/platform/x86/{intel-hid.c => intel/hid.c} (99%)
> rename drivers/platform/x86/{intel_int0002_vgpio.c => intel/int0002_vgpio.c} (100%)
> rename drivers/platform/x86/{intel_ips.c => intel/ips.c} (99%)
> rename drivers/platform/x86/{intel_mrfld_pwrbtn.c => intel/mrfld_pwrbtn.c} (100%)
> rename drivers/platform/x86/{intel_oaktrail.c => intel/oaktrail.c} (100%)
> create mode 100644 drivers/platform/x86/intel/pmc/Kconfig
> create mode 100644 drivers/platform/x86/intel/pmc/Makefile
> rename drivers/platform/x86/{intel_pmc_core.c => intel/pmc/core.c} (99%)
> rename drivers/platform/x86/{intel_pmc_core.h => intel/pmc/core.h} (100%)
> rename drivers/platform/x86/{intel_pmc_core_pltdrv.c => intel/pmc/pltdrv.c} (100%)
> rename drivers/platform/x86/{intel_punit_ipc.c => intel/punit_ipc.c} (100%)
> rename drivers/platform/x86/{intel-rst.c => intel/rst.c} (100%)
> create mode 100644 drivers/platform/x86/intel/scu/Kconfig
> create mode 100644 drivers/platform/x86/intel/scu/Makefile
> rename drivers/platform/x86/{intel_scu_ipc.c => intel/scu/ipc.c} (99%)
> rename drivers/platform/x86/{intel_scu_ipcutil.c => intel/scu/ipcutil.c} (100%)
> rename drivers/platform/x86/{intel_scu_pcidrv.c => intel/scu/pcidrv.c} (100%)
> rename drivers/platform/x86/{intel_scu_pltdrv.c => intel/scu/pltdrv.c} (100%)
> rename drivers/platform/x86/{intel_scu_wdt.c => intel/scu/wdt.c} (100%)
> rename drivers/platform/x86/{intel-smartconnect.c => intel/smartconnect.c} (100%)
> rename drivers/platform/x86/{intel_speed_select_if => intel/speed_select_if}/Kconfig (100%)
> rename drivers/platform/x86/{intel_speed_select_if => intel/speed_select_if}/Makefile (100%)
> rename drivers/platform/x86/{intel_speed_select_if => intel/speed_select_if}/isst_if_common.c (100%)
> rename drivers/platform/x86/{intel_speed_select_if => intel/speed_select_if}/isst_if_common.h (100%)
> rename drivers/platform/x86/{intel_speed_select_if => intel/speed_select_if}/isst_if_mbox_msr.c (100%)
> rename drivers/platform/x86/{intel_speed_select_if => intel/speed_select_if}/isst_if_mbox_pci.c (100%)
> rename drivers/platform/x86/{intel_speed_select_if => intel/speed_select_if}/isst_if_mmio.c (100%)
> create mode 100644 drivers/platform/x86/intel/telemetry/Kconfig
> create mode 100644 drivers/platform/x86/intel/telemetry/Makefile
> rename drivers/platform/x86/{intel_telemetry_core.c => intel/telemetry/core.c} (100%)
> rename drivers/platform/x86/{intel_telemetry_debugfs.c => intel/telemetry/debugfs.c} (100%)
> rename drivers/platform/x86/{intel_telemetry_pltdrv.c => intel/telemetry/pltdrv.c} (100%)
> rename drivers/platform/x86/{intel_turbo_max_3.c => intel/turbo_max_3.c} (100%)
> rename drivers/platform/x86/{intel-uncore-frequency.c => intel/uncore-frequency.c} (100%)
> rename drivers/platform/x86/{intel-vbtn.c => intel/vbtn.c} (99%)
> create mode 100644 drivers/platform/x86/intel/wmi/Kconfig
> create mode 100644 drivers/platform/x86/intel/wmi/Makefile
> rename drivers/platform/x86/{intel-wmi-sbl-fw-update.c => intel/wmi/sbl-fw-update.c} (100%)
> rename drivers/platform/x86/{intel-wmi-thunderbolt.c => intel/wmi/thunderbolt.c} (100%)
>
Powered by blists - more mailing lists