linux-kernel - Re: [PATCH] parport: remove non-zero check on count

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADVatmOudaqZBr+cX_AXwKmDRd2LRTe=C=_bavEki0fdhWkADg@mail.gmail.com>
Date:   Thu, 19 Aug 2021 21:52:07 +0100
From:   Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     kernel-janitors <kernel-janitors@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Colin King <colin.king@...onical.com>
Subject: Re: [PATCH] parport: remove non-zero check on count

On Fri, Jul 30, 2021 at 11:07 AM Colin King <colin.king@...onical.com> wrote:
>
> From: Colin Ian King <colin.king@...onical.com>
>
> The check for count appears to be incorrect since a non-zero count
> check occurs a couple of statements earlier. Currently the check is
> always false and the dev->port->irq != PARPORT_IRQ_NONE part of the
> check is never tested and the if statement is dead-code. Fix this
> by removing the check on count.
>
> Note that this code is pre-git history, so I can't find a sha for
> it.
>
> Addresses-Coverity: ("Logically dead code")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Acked-by: Sudip Mukherjee <sudipm.mukherjee@...il.com>

Greg, can you please take it through your tree..
I think you might not have it in your queue as you were not in the
original recipient list, if so, I can send it after adding my Ack to
it.

-- 
Regards
Sudip