linux-kernel - Re: [PATCH] i2c: virtio: Fix the compiler warning when CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 19 Aug 2021 13:06:51 +1000
From:   Stephen Rothwell <sfr@...b.auug.org.au>
To:     Jie Deng <jie.deng@...el.com>
Cc:     linux-i2c@...r.kernel.org,
        virtualization@...ts.linux-foundation.org,
        linux-kernel@...r.kernel.org, wsa@...nel.org,
        viresh.kumar@...aro.org, conghui.chen@...el.com
Subject: Re: [PATCH] i2c: virtio: Fix the compiler warning when CONFIG_ACPI
 is not set

Hi Jie,

On Thu, 19 Aug 2021 08:48:41 +0800 Jie Deng <jie.deng@...el.com> wrote:
>
> Fix the compiler warning "drivers/i2c/busses/i2c-virtio.c:208:17:
> warning: unused variable 'pdev' [-Wunused-variable]" when CONFIG_ACPI
> is not set.
> 
> Fixes: 8fb12751ac78 ("i2c: virtio: add a virtio i2c frontend driver")

Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>

> Signed-off-by: Jie Deng <jie.deng@...el.com>
> ---
>  drivers/i2c/busses/i2c-virtio.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-virtio.c b/drivers/i2c/busses/i2c-virtio.c
> index d3e60d9..964c601 100644
> --- a/drivers/i2c/busses/i2c-virtio.c
> +++ b/drivers/i2c/busses/i2c-virtio.c
> @@ -205,7 +205,6 @@ static const struct i2c_adapter_quirks virtio_i2c_quirks = {
>  
>  static int virtio_i2c_probe(struct virtio_device *vdev)
>  {
> -	struct device *pdev = vdev->dev.parent;
>  	struct virtio_i2c *vi;
>  	int ret;
>  
> @@ -234,7 +233,7 @@ static int virtio_i2c_probe(struct virtio_device *vdev)
>  	 * Setup ACPI node for controlled devices which will be probed through
>  	 * ACPI.
>  	 */
> -	ACPI_COMPANION_SET(&vi->adap.dev, ACPI_COMPANION(pdev));
> +	ACPI_COMPANION_SET(&vi->adap.dev, ACPI_COMPANION(vdev->dev.parent));
>  
>  	ret = i2c_add_adapter(&vi->adap);
>  	if (ret)

Looks good to me.

-- 
Cheers,
Stephen Rothwell

Content of type "application/pgp-signature" skipped