linux-kernel - Re: [PATCH v2 2/2] pinctrl: qcom: Add SDX65 pincontrol driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 18 Aug 2021 22:09:30 -0500
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     quic_vamslank@...cinc.com
Cc:     agross@...nel.org, linus.walleij@...aro.org,
        manivannan.sadhasivam@...aro.org, linux-arm-msm@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org
Subject: Re: [PATCH v2 2/2] pinctrl: qcom: Add SDX65 pincontrol driver

On Thu 22 Jul 16:18 CDT 2021, quic_vamslank@...cinc.com wrote:
> diff --git a/drivers/pinctrl/qcom/pinctrl-sdx65.c b/drivers/pinctrl/qcom/pinctrl-sdx65.c
[..]
> +enum sdx65_functions {
> +	msm_mux_QLINK0_WMSS,

I think this would be more aesthetically pleasing if it was lower case,
like all the other entries. Can you please fix that?


With that:

Reviewed-by: Bjorn Andersson <bjorn.andersson@...aro.org>

Regards,
Bjorn