linux-kernel - Re: [PATCH][linux-next] net/mlx5: Bridge, fix uninitialized variable in mlx5_esw_bridge_port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f42ff8df9d10b6e171e3ca45247a3df9b9fba71c.camel@nvidia.com>
Date:   Thu, 19 Aug 2021 07:50:51 +0000
From:   Saeed Mahameed <saeedm@...dia.com>
To:     "tim.gardner@...onical.com" <tim.gardner@...onical.com>,
        Vlad Buslov <vladbu@...dia.com>
CC:     "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        Roi Dayan <roid@...dia.com>,
        "vladimir.oltean@....com" <vladimir.oltean@....com>,
        Mark Bloch <mbloch@...dia.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "leon@...nel.org" <leon@...nel.org>,
        Jianbo Liu <jianbol@...dia.com>
Subject: Re: [PATCH][linux-next] net/mlx5: Bridge, fix uninitialized variable
 in mlx5_esw_bridge_port_changeupper()

On Wed, 2021-08-18 at 19:47 +0300, Vlad Buslov wrote:
> On Wed 18 Aug 2021 at 18:52, Tim Gardner <tim.gardner@...onical.com>
> wrote:
> > A recent change removed code that initialized the return code
> > variable 'err'. It
> > is now possible for mlx5_esw_bridge_port_changeupper() to return an
> > error code
> > using this uninitialized variable. Fix it by initializing to 0.
> > 
> > Addresses-Coverity: ("Uninitialized scalar variable (UNINIT)")
> > 
> > Cc: Saeed Mahameed <saeedm@...dia.com>
> > Cc: Leon Romanovsky <leon@...nel.org>
> > Cc: "David S. Miller" <davem@...emloft.net>
> > Cc: Jakub Kicinski <kuba@...nel.org>
> > Cc: Vlad Buslov <vladbu@...dia.com>
> > Cc: Jianbo Liu <jianbol@...dia.com>
> > Cc: Mark Bloch <mbloch@...dia.com>
> > Cc: Roi Dayan <roid@...dia.com>
> > Cc: Vladimir Oltean <vladimir.oltean@....com>
> > Cc: netdev@...r.kernel.org
> > Cc: linux-rdma@...r.kernel.org
> > Cc: linux-kernel@...r.kernel.org

Just wondering, do we really need 12 inline CCs for fixing a poor
coverity?

> > Signed-off-by: Tim Gardner <tim.gardner@...onical.com>
> > ---
> 
> Tim, thanks for fixing this!
> 
> Saeed, this is the second similar issue that I mentioned in my reply
> to
> Colin. Again, I've already submitted same patch internally and this
> one
> is as good as mine.

I don't mind both patches are perfect.

> 
> Reviewed-by: Vlad Buslov <vladbu@...dia.com>
> 
> [...]
> 
>